REST : deprecate field_data for Clear Indices Cache API#28943
REST : deprecate field_data for Clear Indices Cache API#28943nik9000 merged 3 commits intoelastic:masterfrom
field_data for Clear Indices Cache API#28943Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
FYI @elastic/es-core-infra. |
|
Makes sense to me. @olcbean, could you add a yaml test for this API that just calls it with the new parameter to make sure the new preferred name? That'd make sure that we parse it and should be quite quick. I think the right thing to do is, once this is ready, to merge it to master and 6.x and, in a followup, remove the now-deprecated name. @olcbean, would you like to do the follow-up? @elasticmachine, test this please. |
|
do we want to deprecate in 6.x and remove in 7.0? If so the migrate guide has to be updated. |
|
Hm... The question is how to handle the docs ? Should I add a deprecation msg and if so, if I open the PR against master I do not have access to the 6.x migration docs ... I see two possible ways to proceed.
|
We'll generate a changes list automatically. The script should pick up anything with |
|
@elasticmachine, test this please |
|
It looks like the PR test failures are because this needs to be simultaneously backported. That is no problem. I'll test locally. |
In order to fix the tests, the correct version needs to be skipped until the backport is done. Relates #28943
|
I have pushed 9f2c4df to fix failing tests until the backport is done. |
We call it `fielddata` everywhere else in the code and API so we may as well be consistent.
I pushed the backport and reverted this. Sorry for the noise. |
Throughout the code and the documentation
fielddatais used. Only for the Clear Indices Cache APIfield_datahas been used :elasticsearch/server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestClearIndicesCacheAction.java
Line 104 in 95a13ea
( if
fielddatais used as a url param, a deprecation warning is logged and also returned in the response headers )Also the reference docs are referring only to
fielddata.For consistency reasons this PR deprecates
field_datain favor offielddata.For context, a few usages of
fielddata:Index setting :
index.fielddata.cacheThe change from
fielddatatofield_datahas been done in e2c8ff9 ( at this point the two names were interchangeable : no deprecation logging )Since b927cfe (#17804) a http warning header is sent for the deprecated usage