Merged
Conversation
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
cbuescher
approved these changes
Feb 19, 2018
Member
cbuescher
left a comment
There was a problem hiding this comment.
@alejandro-carstens thanks for the correction, LGTM
cbuescher
pushed a commit
that referenced
this pull request
Feb 19, 2018
cbuescher
pushed a commit
that referenced
this pull request
Feb 19, 2018
cbuescher
pushed a commit
that referenced
this pull request
Feb 19, 2018
cbuescher
pushed a commit
that referenced
this pull request
Feb 19, 2018
cbuescher
pushed a commit
that referenced
this pull request
Feb 19, 2018
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 19, 2018
* master: Enable selecting adaptive selection stats Remove leftover mention of file-based scripts Fix threading issue on listener notification (elastic#28730) Revisit deletion policy after release the last snapshot (elastic#28627) Remove unused method Track deletes only in the tombstone map instead of maintaining as copy (elastic#27868) [Docs] Correct typo in README.textile (elastic#28716) Fix AdaptiveSelectionStats serialization bug (elastic#28718) TEST: Fix InternalEngine#testAcquireIndexCommit Add note on temporary directory for Windows service Added coming annotation and breaking changes link to release notes script Remove leftover PR link for previously disabled bwc tests Separate acquiring safe commit and last commit (elastic#28271) Fix BWC issue of the translog last modified age stats
Contributor
Author
|
Thank you *@cbuescher *you guys are doing an amazing job, thanks for all
your hard work (I'm an engineer at Stitch Labs and we couldn't operate
without your product, we index around 51 million documents daily).
All the best.
Alejandro
2018-02-19 1:32 GMT-08:00 Christoph Büscher <notifications@github.com>:
… ***@***.**** approved this pull request.
@alejandro-carstens <https://github.com/alejandro-carstens> thanks for
the correction, LGTM
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28716 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWPjBuidC_YqjTGCO9IpP5E3oXEKKpkIks5tWT_BgaJpZM4SJkEQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing readme typo.
gradle check?