Skip to content

Removed redundant JSON field from Put Mapping docs#28514

Merged
javanna merged 1 commit intoelastic:masterfrom
catalin-ursachi:simplify-put-mapping-test
Feb 13, 2018
Merged

Removed redundant JSON field from Put Mapping docs#28514
javanna merged 1 commit intoelastic:masterfrom
catalin-ursachi:simplify-put-mapping-test

Conversation

@catalin-ursachi
Copy link
Copy Markdown
Contributor

@catalin-ursachi catalin-ursachi commented Feb 4, 2018

While it's possible to provide a mapping source to Put Mapping as:

{
  "type_name": {
    "properties: { ... }
  }
}

the actual API docs suggest using simply:

{
  "properties": { ... }
}

I've simplified the Rest client docs accordingly.

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Feb 4, 2018

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Feb 4, 2018

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cbuescher cbuescher added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types :Data Management/Indices APIs DO NOT USE. Use ":Distributed/Indices APIs" or ":StorageEngine/Templates" instead. and removed :Data Management/Indices APIs DO NOT USE. Use ":Distributed/Indices APIs" or ":StorageEngine/Templates" instead. labels Feb 5, 2018
@mayya-sharipova
Copy link
Copy Markdown
Contributor

mayya-sharipova commented Feb 6, 2018

jenkins, please test this

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Feb 7, 2018

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Feb 7, 2018

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@mayya-sharipova
Copy link
Copy Markdown
Contributor

mayya-sharipova commented Feb 12, 2018

jenkins, please test this

@catalin-ursachi
Copy link
Copy Markdown
Contributor Author

catalin-ursachi commented Feb 13, 2018

As far as I can tell, the test failure is spurious. (Also, the tests had successfully passed last time round - but I accidentally closed and then reopened the PR).

@javanna javanna added :Java High Level REST Client and removed :Search Foundations/Mapping Index mappings, including merging and defining field types labels Feb 13, 2018
@javanna javanna self-requested a review February 13, 2018 11:12
javanna
javanna approved these changes Feb 13, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @catalin-ursachi LGTM

@javanna javanna merged commit ee00523 into elastic:master Feb 13, 2018
javanna pushed a commit that referenced this pull request Feb 13, 2018
@catalin-ursachi @javanna
Removed redundant JSON object from Put Mapping docs (#28514)
90ac017
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 15, 2018
@jasontedor
Merge branch 'master' into async-errors
842f331 
* master:
  Backported synced-flush PR to v5.6.8 and v6.2.2
  Move more XContent.createParser calls to non-deprecated version (elastic#28672)
  Move more XContent.createParser calls to non-deprecated version (elastic#28670)
  Build: Group archive and package distribution projects (elastic#28673)
  [DOCS] Add supported token filters
  [TEST] bump timeout in testFetchShardsSkipUnavailable to 5s
  Relax remote check for bwc project checkouts (elastic#28666)
  [TEST] Synchronize searcher list in IndexShardTests
  [TEST] packaging: function to collect debug info (elastic#28608)
  Compute declared versions in a static block
  Docs: Remove references to elasticsearch directory in plugins (elastic#28647)
  Remove snapshot conditional for bwc snapshots (elastic#28657)
  Removed redundant JSON object from Put Mapping docs (elastic#28514)
  Update threadpool.asciidoc target_response_time (elastic#28655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@javanna javanna javanna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>docs General docs changes v6.3.0 v7.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@catalin-ursachi @elasticmachine @mayya-sharipova @javanna @colings86 @cbuescher