Start switching to non-deprecated ParseField.match method#28488
Merged
dakrone merged 1 commit intoelastic:masterfrom Feb 2, 2018
Merged
Start switching to non-deprecated ParseField.match method#28488dakrone merged 1 commit intoelastic:masterfrom
dakrone merged 1 commit intoelastic:masterfrom
Conversation
This commit switches all the modules and server test code to use the non-deprecated `ParseField.match` method, passing in the parser's deprecation handler or the logging deprecation handler when a parser is not available (like in tests). Relates to elastic#28449
Member
Author
|
This one replaces #28487 |
nik9000
approved these changes
Feb 1, 2018
| module.getNamedXContents().stream() | ||
| .filter(entry -> entry.categoryClass.equals(BaseAggregationBuilder.class) && entry.name.match("test")) | ||
| .filter(entry -> entry.categoryClass.equals(BaseAggregationBuilder.class) && | ||
| entry.name.match("test", LoggingDeprecationHandler.INSTANCE)) |
Member
There was a problem hiding this comment.
These might be better if they just fail rather than go to the DepercationLogger. This is fine though.
Member
Author
There was a problem hiding this comment.
I think for now this works and maybe once everything is cut over, we can make the single arity one use the unsupported operation exception version, either way, we can change this pretty easily later.
dakrone
added a commit
that referenced
this pull request
Feb 2, 2018
This commit switches all the modules and server test code to use the non-deprecated `ParseField.match` method, passing in the parser's deprecation handler or the logging deprecation handler when a parser is not available (like in tests). Relates to #28449
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit switches all the modules and server test code to use the
non-deprecated
ParseField.matchmethod, passing in the parser's deprecationhandler or the logging deprecation handler when a parser is not available (like
in tests).
Relates to #28449