Fix Gradle wrapper usage on Windows when building BWC#28146
Merged
ywelsch merged 1 commit intoelastic:masterfrom Jan 9, 2018
Merged
Fix Gradle wrapper usage on Windows when building BWC#28146ywelsch merged 1 commit intoelastic:masterfrom
ywelsch merged 1 commit intoelastic:masterfrom
Conversation
Member
|
@ywelsch I'm not too familiar with the build, let alone windows. Can you briefly explain what this changes? |
Contributor
Author
|
On Windows,
See "Windows Users" section of https://ant.apache.org/manual/Tasks/exec.html It's the same pattern we've been using in other places, see also |
cbuescher
approved these changes
Jan 9, 2018
Member
cbuescher
left a comment
There was a problem hiding this comment.
Thanks for the explanation, got it now. LGTM.
ywelsch
added a commit
that referenced
this pull request
Jan 9, 2018
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 9, 2018
* master: Fix Gradle wrapper usage on Windows when building BWC (elastic#28146) [Docs] Fix some typos in comments (elastic#28098)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 9, 2018
* master: (27 commits) Declare empty package dirs as output dirs Consistent updates of IndexShardSnapshotStatus (elastic#28130) Fix Gradle wrapper usage on Windows when building BWC (elastic#28146) [Docs] Fix some typos in comments (elastic#28098) Use Gradle wrapper when building BWC Painless: Add a simple cache for whitelist methods and fields. (elastic#28142) Fix upgrading indices which use a custom similarity plugin. (elastic#26985) Fix Licenses values for CDDL and Custom URL (elastic#27999) Cleanup TcpChannelFactory and remove classes (elastic#28102) Fix expected plugins test for transport-nio [Docs] Fix Date Math example descriptions (elastic#28125) Fail rollover if duplicated alias found in template (elastic#28110) Avoid concurrent snapshot finalizations when deleting an INIT snapshot (elastic#28078) Deprecate `isShardsAcked()` in favour of `isShardsAcknowledged()` (elastic#27819) [TEST] Wait for replicas to be allocated before shrinking Use the underlying connection version for CCS connections (elastic#28093) test: do not use asn fields Test: Add assumeFalse for test that cannot pass on windows Clarify reproduce info on Windows Remove out-of-date projectile file ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #28138