Merged
Conversation
We have agreed to introduce the Gradle wrapper to simplify workflows for developers, and managing infrastructure (e.g., CI, release builds, etc.) as well as consideration for the fact that other projects in our stack use Gradle and do not necessarily want to be tied to our Gradle version.
nik9000
approved these changes
Jan 3, 2018
Member
nik9000
left a comment
There was a problem hiding this comment.
I don't want the binary in the repo but I really don't want to wrangle with gradle upgrades and I like that we can rely on a particular version of gradle with this. This is an improvement overall so let's do it.
ywelsch
reviewed
Jan 4, 2018
Contributor
ywelsch
left a comment
There was a problem hiding this comment.
Looks good to me. I've left two suggestions and one question.
build.gradle
Outdated
| int bytesRead | ||
| while ((bytesRead = i.read(buffer)) >= 0) { | ||
| if (bytesRead > 0) { | ||
| sha256.update(buffer, 0, bytesRead) |
Contributor
There was a problem hiding this comment.
maybe simpler to just write
String checksum = MessageDigest.getInstance("SHA-256").digest(uri.toURL().getBytes()).encodeHex().toString()
Member
Author
There was a problem hiding this comment.
It is simpler, but I would prefer not to download an arbitrary number of bytes into memory in one go. This is why I chunk it.
build.gradle
Outdated
| tasks.withType(Wrapper).each(wrapperClosure) | ||
|
|
||
| subprojects { | ||
| tasks.withType(Wrapper).each(wrapperClosure) |
Contributor
There was a problem hiding this comment.
you can fold this call with the previous one into
allprojects {
tasks.withType(Wrapper).each(wrapperClosure)
}
|
|
||
| task wrapper(type: Wrapper) | ||
|
|
||
| gradle.projectsEvaluated { |
ywelsch
approved these changes
Jan 4, 2018
jasontedor
added a commit
that referenced
this pull request
Jan 4, 2018
We have agreed to introduce the Gradle wrapper to simplify workflows for developers, and managing infrastructure (e.g., CI, release builds, etc.) as well as consideration for the fact that other projects in our stack use Gradle and do not necessarily want to be tied to our Gradle version. Relates #28065
jasontedor
added a commit
that referenced
this pull request
Jan 4, 2018
We have agreed to introduce the Gradle wrapper to simplify workflows for developers, and managing infrastructure (e.g., CI, release builds, etc.) as well as consideration for the fact that other projects in our stack use Gradle and do not necessarily want to be tied to our Gradle version. Relates #28065
jasontedor
added a commit
that referenced
this pull request
Jan 4, 2018
We have agreed to introduce the Gradle wrapper to simplify workflows for developers, and managing infrastructure (e.g., CI, release builds, etc.) as well as consideration for the fact that other projects in our stack use Gradle and do not necessarily want to be tied to our Gradle version. Relates #28065
jasontedor
added a commit
that referenced
this pull request
Jan 4, 2018
We have agreed to introduce the Gradle wrapper to simplify workflows for developers, and managing infrastructure (e.g., CI, release builds, etc.) as well as consideration for the fact that other projects in our stack use Gradle and do not necessarily want to be tied to our Gradle version. Relates #28065
This was referenced Jan 5, 2018
jaymode
added a commit
to elastic/shield-custom-realm-example
that referenced
this pull request
Feb 21, 2018
jaymode
added a commit
to elastic/shield-custom-realm-example
that referenced
this pull request
Feb 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have agreed to introduce the Gradle wrapper to simplify workflows for developers, and managing infrastructure (e.g., CI, release builds, etc.) as well as consideration for the fact that other projects in our stack use Gradle and do not necessarily want to be tied to our Gradle version.
Relates #13744