Skip to content

Fix cluster.routing.allocation.enable and cluster.routing.rebalance.enable case#28037

Merged
ywelsch merged 2 commits intoelastic:masterfrom
liketic:fix-issues/28007
Jan 3, 2018
Merged

Fix cluster.routing.allocation.enable and cluster.routing.rebalance.enable case#28037
ywelsch merged 2 commits intoelastic:masterfrom
liketic:fix-issues/28007

Conversation

@liketic
Copy link
Copy Markdown

@liketic liketic commented Dec 31, 2017

Fixes the default value of cluster.routing.allocation.enable and cluster.routing.rebalance.enable to be lower-case.

Closes #28007

@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ywelsch
Copy link
Copy Markdown
Contributor

ywelsch commented Jan 2, 2018

@elasticmachine test this please

@ywelsch
Copy link
Copy Markdown
Contributor

ywelsch commented Jan 3, 2018

@liketic I think there's no need to change the parsing here. The only issue is that the default value is shown in upper-case. It's good enough to add the toString() that does lower-casing and then use toString() for the default value.

@liketic
Copy link
Copy Markdown
Author

liketic commented Jan 3, 2018

Thanks @ywelsch

@ywelsch
Copy link
Copy Markdown
Contributor

ywelsch commented Jan 3, 2018

@elasticmachine retest this please

@ywelsch ywelsch merged commit bccf030 into elastic:master Jan 3, 2018
@ywelsch
Copy link
Copy Markdown
Contributor

ywelsch commented Jan 3, 2018

Thanks @liketic

ywelsch pushed a commit that referenced this pull request Jan 3, 2018
…nable casing (#28037)

Fixes the default value of cluster.routing.allocation.enable and cluster.routing.rebalance.enable to be lower-case.
@liketic liketic deleted the fix-issues/28007 branch January 4, 2018 02:24
martijnvg added a commit that referenced this pull request Jan 4, 2018
* es/master: (53 commits)
  Bump compat version for local depdendent test to 6.2.0
  Pass `java.locale.providers=COMPAT` to Java 9 onwards (#28080)
  Allow shrinking of indices from a previous major (#28076)
  Remove deprecated exceptions (#28059)
  Add Writeable.Reader support to TransportResponseHandler (#28010)
  Plugins: Add plugin extension capabilities (#27881)
  Fix cluster.routing.allocation.enable and cluster.routing.rebalance.enable casing (#28037)
  [Test] Fix scores for dcg in RankEvalRequestIT and RankEvalYamlIT
  [Docs] Add note on limitation for significant_text with nested objects (#28052)
  Enable convert processor to support Long and Double. (#27957)
  Enable Wildfly tests on JDK 9 and JDK 10
  [Test] Fix allowed delta for calculated scores in DiscountedCumulativeGainTests
  [Test] Mute DiscountedCumulativeGainTests on ARM
  Only bind loopback addresses when binding to local
  Fix assertion in Wildfly build
  Fix typo in comment in Wildfly build
  Use ephemeral ports in Wildfly tests
  Update fuzzy-query.asciidoc (#28032)
  Just another elasticsearch library (#27996)
  Disable nio test transport (#28028)
  ...
martijnvg added a commit that referenced this pull request Jan 4, 2018
* es/6.x: (48 commits)
  Bump compat version for local depdendent test to 6.2.0
  Pass `java.locale.providers=COMPAT` to Java 9 onwards (#28080)
  Allow shrinking of indices from a previous major (#28076)
  Add Writeable.Reader support to TransportResponseHandler (#28010)
  Fix cluster.routing.allocation.enable and cluster.routing.rebalance.enable casing (#28037)
  [Test] Fix scores for dcg in RankEvalRequestIT and RankEvalYamlIT
  [Docs] Add note on limitation for significant_text with nested objects (#28052)
  [Test] Fix allowed delta for calculated scores in DiscountedCumulativeGainTests
  Enable convert processor to support Long and Double. (#27957)
  Enable Wildfly tests on JDK 9 and JDK 10
  update ingest-attachment to use Tika 1.17 and newer deps (#27824)
  Only bind loopback addresses when binding to local
  Fix assertion in Wildfly build
  Fix typo in comment in Wildfly build
  Use ephemeral ports in Wildfly tests
  Update fuzzy-query.asciidoc (#28032)
  Add node id to shard failure message (#28024)
  Introduce limit to the number of terms in Terms Query (#27968)
  Upgrade Gradle Shadow plugin to 2.0.2
  Upgrade to JMH 1.19
  ...
@lcawl lcawl added :Search/Search Search-related issues that do not fall into other categories and removed :Allocation labels Feb 13, 2018
@clintongormley clintongormley added :Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. and removed :Search/Search Search-related issues that do not fall into other categories labels Feb 13, 2018
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >enhancement v6.2.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants