Don't refresh shard on activation#28013
Merged
ywelsch merged 1 commit intoelastic:masterfrom Feb 6, 2018
Merged
Conversation
e330a31 to
5e0376c
Compare
Contributor
Author
|
ping @bleskes @jasontedor |
bleskes
approved these changes
Feb 6, 2018
Contributor
bleskes
left a comment
There was a problem hiding this comment.
LGTM. I did some archaeology to see when this was added (1.0) and I think we are now in a different universe (refresh is a replication action) and don't need it indeed.
jasontedor
reviewed
Feb 6, 2018
| try { | ||
| getEngine().refresh("cluster_state_started"); | ||
| } catch (Exception e) { | ||
| logger.debug("failed to refresh due to move to cluster wide started", e); |
ywelsch
added a commit
that referenced
this pull request
Feb 6, 2018
A shard is fully baked when it moves to POST_RECOVERY. There is no need to do an extra refresh on shard activation again as the shard has already been refreshed when it moved to POST_RECOVERY.
martijnvg
added a commit
that referenced
this pull request
Feb 7, 2018
* es/master: Added more parameter to PersistentTaskPlugin#getPersistentTasksExecutor(...) [Tests] Relax assertion in SuggestStatsIT (#28544) Make internal Rounding fields final (#28532) Fix the ability to remove old plugin [TEST] Expand failure message for wildfly integration tests Add 6.2.1 version constant Remove feature parsing for GetIndicesAction (#28535) No refresh on shard activation needed (#28013) Improve failure message when restoring an index that already exists in the cluster (#28498) Use right skip versions. [Docs] Fix incomplete URLs (#28528) Use non deprecated xcontenthelper (#28503) Painless: Fixes a null pointer exception in certain cases of for loop usage (#28506)
martijnvg
added a commit
that referenced
this pull request
Feb 7, 2018
* es/6.x: Added more parameter to PersistentTaskPlugin#getPersistentTasksExecutor(...) [Tests] Relax assertion in SuggestStatsIT (#28544) Make internal Rounding fields final (#28532) Skip verify versions for buggy cgroup2 handling Fix the ability to remove old plugin [TEST] Expand failure message for wildfly integration tests Add 6.2.1 version constant [DOCS] Adding 6.2 RNs [DOCS] Added entry for 6.2.0 RNs Remove feature parsing for GetIndicesAction (#28535) No refresh on shard activation needed (#28013) Improve failure message when restoring an index that already exists in the cluster (#28498) testIndexCausesIndexCreation should not use the `_primary` preference Use right skip versions. [Docs] Fix incomplete URLs (#28528) Use non deprecated xcontenthelper (#28503) Painless: Fixes a null pointer exception in certain cases of for loop usage (#28506)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A shard is fully baked when it moves to POST_RECOVERY. There is no need to do an extra refresh on shard activation again as the shard has already been refreshed when it moved to POST_RECOVERY (relates to #26055).