Fixed Indices information breaking changes#27914
Merged
Conversation
cbuescher
requested changes
Jan 4, 2018
Member
cbuescher
left a comment
There was a problem hiding this comment.
@codebrain I left two small comments, other than that looks good. Do you want to merge this yourself or should I merge it once you updated the PR?
| @@ -73,8 +73,10 @@ Previously it was possible to execute `GET /_aliases,_mappings` or `GET | |||
| in order to retrieve multiple types of information about one or more indices. | |||
| This comma-separation for retrieving multiple pieces of information has been | |||
| removed.. `GET /_all` can be used to retrieve all aliases, settings, and | |||
Member
There was a problem hiding this comment.
nit: maybe also remove one of the double full-stops while changing this file
| `GET /myindex/_mappings` (or `_aliases`, or `_settings`). | ||
| mappings for all indices. | ||
|
|
||
| In order to retrieve only the mappings for an index, |
Member
There was a problem hiding this comment.
nit: maybe change to singular "mapping" here as well for consistency. Maybe also add a verb (like "In order to..., use...) to make it a full sentence.
added 2 commits
January 24, 2018 16:12
cbuescher
approved these changes
Jan 24, 2018
Member
cbuescher
left a comment
There was a problem hiding this comment.
@codebrain thanks, will merge
Member
|
@elasticmachien test this please |
Member
|
CI is not happy that this branch doesn't contain gradlew yet, but I built the docs locally and will merge this since it doesn't involve code snippet changes etc... |
cbuescher
pushed a commit
that referenced
this pull request
Jan 24, 2018
cbuescher
pushed a commit
that referenced
this pull request
Jan 24, 2018
cbuescher
pushed a commit
that referenced
this pull request
Jan 24, 2018
martijnvg
added a commit
that referenced
this pull request
Jan 25, 2018
* es/6.x: [Docs] Fix explanation for `from` and `size` example (#28320) Adapt bwc version after backport #28358 Always return the after_key in composite aggregation response (#28358) Adds a note in the `terms` aggregation docs regarding pagination (#28360) Update packaging tests to work with meta plugins (#28336) Remove Painless Type from MethodWriter in favor of Java Class. (#28346) [Doc] Fixs typo in reverse-nested-aggregation.asciidoc (#28348) [Docs] Fixed Indices information breaking changes (#27914) Reindex: Shore up rethrottle test isHeldByCurrentThread should return primitive bool [Docs] Clarify `html` encoder in highlighting.asciidoc (#27766) Only assert single commit iff index created on 6.2 Deprecate the `update_all_types` option. (#28284) Fix GeoDistance query example Settings: Introduce settings updater for a list of settings (#28338) [Docs] Fix asciidoc style in composite agg docs Adapt bwc version after backport #28310 Adds the ability to specify a format on composite date_histogram source (#28310)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation is incorrect.
_aliasis the preferred endpoint, not_aliases_mappingis the preferred endpoint, not_mappings