Enable convert processor to support Long and Double#27891
Closed
kiawin wants to merge 2 commits intoelastic:masterfrom
Closed
Enable convert processor to support Long and Double#27891kiawin wants to merge 2 commits intoelastic:masterfrom
kiawin wants to merge 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Member
|
@elasticmachine test this please |
Member
|
Thanks @kiawin, I'll take a look at this. |
martijnvg
requested changes
Dec 21, 2017
Member
martijnvg
left a comment
There was a problem hiding this comment.
I left one commit. Looks good otherwise.
| return LONG.convert(value); | ||
| } catch (IllegalArgumentException e) {} | ||
| try { | ||
| return DOUBLE.convert(value); |
Member
There was a problem hiding this comment.
move the double parsing below the float parsing? So that it is consistent with integer/long auto parsing.
Contributor
Author
|
Hmm, what's the best practice for squashing? GitHub detected I recreated the branch after I rebase it. Anyway, I submitted another PR in #27957. Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code written based on feature request #23085 with consideration taken from #23423.