Allow `_doc` as a type. by jpountz · Pull Request #27816 · elastic/elasticsearch

jpountz · 2017-12-14T12:57:56Z

Allowing _doc as a type will enable users to make the transition to 7.0
smoother since the index APIs will be PUT index/_doc/id and POST index/_doc.
This also moves same tests and most of the documentation to _doc as a type name.

Closes #27750
Closes #27751

Allowing `_doc` as a type will enable users to make the transition to 7.0 smoother since the index APIs will be `PUT index/_doc/id` and `POST index/_doc`. This also moves most of the documentation to `_doc` as a type name. Closes elastic#27750 Closes elastic#27751

clintongormley

I couldn't check all 196(!) files, but it looks like you've got most things, thank you.

Added some comments about the removal of types page.

clintongormley · 2017-12-14T13:14:49Z

docs/reference/mapping/removal_of_types.asciidoc

      }
    },
-    "tweet": {
+    "_doc": {


this one shouldn't change

clintongormley · 2017-12-14T13:16:32Z

docs/reference/mapping/removal_of_types.asciidoc

@@ -187,7 +187,7 @@ PUT twitter/doc/user-kimchy



doc in lines 167 and 180 could become _doc

Line 167 still needs changing

clintongormley · 2017-12-14T13:16:48Z

docs/reference/mapping/removal_of_types.asciidoc

 PUT twitter/doc/tweet-1
 {
-  "type": "tweet", <1>
+  "type": "_doc", <1>


this one shouldn't change

clintongormley · 2017-12-14T13:17:03Z

docs/reference/mapping/removal_of_types.asciidoc

      "filter": {
        "match": {
-          "type": "tweet" <1>
+          "type": "_doc" <1>


this one shouldn't change

clintongormley · 2017-12-14T13:18:11Z

docs/reference/mapping/removal_of_types.asciidoc

@@ -320,7 +320,7 @@ PUT tweets
    "index.mapping.single_type": true
  },
  "mappings": {


In line 242 above, under changes coming in 6.x, mention addition of _doc as an acceptable type name to ease the transition to new URLs

clintongormley · 2017-12-14T13:19:11Z

docs/reference/mapping/removal_of_types.asciidoc

  "source": {
    "index": "twitter",
-    "type": "tweet"
+    "type": "_doc"


this is the source, so the type name should remain

clintongormley · 2017-12-14T13:20:13Z

docs/reference/mapping/removal_of_types.asciidoc

    "index": "twitter",
-    "type": "tweet"
+    "type": "_doc"
  },


in lines 375 and 413 below, use _doc instead of doc

jpountz · 2017-12-14T13:43:14Z

@clintongormley done

clintongormley

One missed change and a couple of suggestions, otherwise LGTM

clintongormley · 2017-12-14T13:52:32Z

docs/reference/mapping/removal_of_types.asciidoc

@@ -187,7 +187,7 @@ PUT twitter/doc/user-kimchy



Line 167 still needs changing

clintongormley · 2017-12-14T13:53:33Z

docs/reference/mapping/removal_of_types.asciidoc

-  can be used for the type, but there can be only one.
+  can be used for the type, but there can be only one. The preferred type name
+  is `_doc`, so that index APIs have the same path as they will have in 7.0:
+  `PUT index/_doc/id` and `POST index/_doc`


perhaps PUT {index}/_doc/{id} instead?

clintongormley · 2017-12-14T13:53:42Z

docs/reference/mapping/removal_of_types.asciidoc

-  a document no longer requires a document `type`.
+  a document no longer requires a document `type`.  The new index APIs
+  are `PUT index/_doc/id` in case of explicit ids and `POST index/_doc`
+  for auto-generated ids.


same here. perhaps PUT {index}/_doc/{id} instead?

Allowing `_doc` as a type will enable users to make the transition to 7.0 smoother since the index APIs will be `PUT index/_doc/id` and `POST index/_doc`. This also moves most of the documentation to `_doc` as a type name. Closes #27750 Closes #27751

The test assumes that all 6.x indices support `_doc` as a type name but support for it was actually only added in 6.2 via elastic#27816.

The test assumed that it could run against all 6.x indices but it actually requires 6.2+ since 6.2 is the first version that allowed `_doc` as a type name (elastic#27816). Closes elastic#38202

…`. (#39054) The test assumed that it could run against all 6.x indices but it actually requires 6.2+ since 6.2 is the first version that allowed `_doc` as a type name (#27816). Closes #38202

Allow _doc as a type.

3a7a138

Allowing `_doc` as a type will enable users to make the transition to 7.0 smoother since the index APIs will be `PUT index/_doc/id` and `POST index/_doc`. This also moves most of the documentation to `_doc` as a type name. Closes elastic#27750 Closes elastic#27751

jpountz added :Search Foundations/Mapping Index mappings, including merging and defining field types >enhancement labels Dec 14, 2017

jpountz requested a review from clintongormley December 14, 2017 12:57

jpountz added v6.2.0 v7.0.0 labels Dec 14, 2017

clintongormley suggested changes Dec 14, 2017

View reviewed changes

iter

d49566c

clintongormley approved these changes Dec 14, 2017

View reviewed changes

iter

46bba8f

jpountz merged commit 1b66082 into elastic:master Dec 14, 2017

jpountz deleted the enhancement/_doc_as_a_type branch December 14, 2017 16:49

jpountz mentioned this pull request Dec 19, 2017

add template for elasticsearch 7.x logstash-plugins/logstash-output-elasticsearch#713

Merged

jakelandis mentioned this pull request Feb 13, 2018

Use of _default_ in default 6.x template logstash-plugins/logstash-output-elasticsearch#734

Open

olcbean mentioned this pull request Feb 17, 2018

[docs] Replace tweet type with _doc to reflect the code snippets #28715

Merged

IllyaMoskvin mentioned this pull request Feb 26, 2018

Add Elasticsearch 6 support ErickTamayo/laravel-scout-elastic#91

Closed

olcbean mentioned this pull request Mar 15, 2018

Docs: HighLevelRestClient#exists #29073

Merged

sandstrom mentioned this pull request May 3, 2018

Document mapping type name can't start with '_', found: [_doc] uken/fluent-plugin-elasticsearch#376

Closed

coffeeburrito mentioned this pull request Nov 16, 2018

Compatibility with ElasticSearch v6.x and 7.x elasticquent/Elasticquent#175

Open

danielberkompas mentioned this pull request Dec 6, 2018

Document mapping type name can't start with '_' danielberkompas/elasticsearch-elixir#52

Closed

henrikno mentioned this pull request Jan 11, 2019

Beats can't to write to older versions of ES than 6.2 due to _doc elastic/beats#10012

Closed

colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

jpountz mentioned this pull request Feb 18, 2019

Fix skip versions of indices.put_mapping/20_mix_typeless_typeful.yml. #39054

Merged

eynand mentioned this pull request Mar 9, 2019

make compatible with Elasticsearch 6.x fhamborg/news-please#86

Merged

DaveCTurner mentioned this pull request Jul 23, 2019

Fix type inconsistencies in 6.x docs examples #44670

Closed

fantapsody mentioned this pull request Jan 10, 2020

Elasticsearch 5.x Sink connector incompatible apache/pulsar#5690

Closed

Conversation

jpountz commented Dec 14, 2017

Uh oh!

clintongormley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jpountz commented Dec 14, 2017

Uh oh!

clintongormley left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants