Remove delimited_payload_filter#27705
Conversation
ec17144 to
7f64c6e
Compare
delimited_payload_filter
7f64c6e to
28d3e05
Compare
|
@cbuescher LGTM, +1 after rebasing. Also, a general question: after we rename So, does the progression follows from deprecation -> error -> removing not used code? |
28d3e05 to
80d9427
Compare
|
@mayya-sharipova thanks for the review, I rebase to get a new CI run. I will hold back merging this for a bit because I also want to check what needs to be done to add this to the migration assistant as part of #27704 |
There was a problem hiding this comment.
not to self: "in" missing after "Using it"
There was a problem hiding this comment.
same here, somethings missing after "created in"
|
Can this be merged @cbuescher ? cc @elastic/es-search-aggs |
80d9427 to
783749a
Compare
|
@romseygeek almost ready to go, but I still want to check if anything needs to be done with regard to #26625 (comment) where adding some checks to the migration assistant is mentioned. Don't know what to do about it yet. |
|
Merging this now that adding this change to the migration assistant is tracked elsewhere. |
Relates: elastic/elasticsearch#27705 This commit adds support for the deprecated delimited_payload_filter name when deserializing token filters in a 6.x index within a 7.x cluster. When serializing, the new name delimited_payload will be used.
…3835) Relates: elastic/elasticsearch#27705 This commit adds support for the deprecated delimited_payload_filter name when deserializing token filters in a 6.x index within a 7.x cluster. When serializing, the new name delimited_payload will be used.
From 7.0 on, using
delimited_payload_filtershould throw an error (the use was deprecated in 6.2 in favour ofdelimited_payloadin #26625.Relates to #27704