[DOCS] Fix script_field example script#27618
Closed
honzakral wants to merge 1 commit intoelastic:masterfrom
Closed
[DOCS] Fix script_field example script#27618honzakral wants to merge 1 commit intoelastic:masterfrom
honzakral wants to merge 1 commit intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search-aggs |
Member
|
This PR can be closes, the documentation has been fixed on master by fb5b2df, which has been backported to all the 6.x branches. To check the question by @rjernst, I ran the docs:check for the "old" version and it doesn't fail indeed. When moving the test setup that happens in the second snippet in this file up, the docs test fails. I think I will open a PR to do this and discuss the why/how there. |
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
May 17, 2018
Currently the first snippet in the documentation test in script-fields.asciidoc isn't executed, although it has the CONSOLE annotation. Adding a test setup annotation to it seems to fix the problem. Relates to elastic#27618
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplied example doesn't even compile