Merged
Conversation
Mpdreamz
requested changes
Nov 14, 2017
Member
Mpdreamz
left a comment
There was a problem hiding this comment.
Awesome! Left a small comment around INSTALLDIR
| The **exception** to this is `INSTALLDIR` (if originally specified), which must be a different directory to the | ||
| current installation. | ||
| If setting `INSTALLDIR`, we recommend that the final directory in the path be the version of Elasticsearch e.g. | ||
| ++C:\Program Files\Elastic\Elasticsearch\{version}++ |
Member
There was a problem hiding this comment.
Not just recommended but currently we have to mandate the installer ends in the version when running the silent install otherwiae the install will fail. THE UI can cope with this though.
Contributor
Author
There was a problem hiding this comment.
I think the installer should only mandate that the directory for the upgrade version is different to the existing version, and not a child directory of the existing version.
Contributor
Author
|
I updated the description for |
Mpdreamz
approved these changes
Nov 15, 2017
russcam
added a commit
that referenced
this pull request
Nov 15, 2017
* Add additional command line parameters along with important note for INSTALLDIR when upgrading * Update windows installer images (cherry picked from commit c42899b)
russcam
added a commit
that referenced
this pull request
Nov 15, 2017
* Add additional command line parameters along with important note for INSTALLDIR when upgrading * Update windows installer images (cherry picked from commit c42899b)
jasontedor
added a commit
that referenced
this pull request
Nov 16, 2017
* master: Stop skipping REST test after backport of #27056 Fix default value of ignore_unavailable for snapshot REST API (#27056) Add composite aggregator (#26800) Fix `ShardSplittingQuery` to respect nested documents. (#27398) [Docs] Restore section about multi-level parent/child relation in parent-join (#27392) Add TcpChannel to unify Transport implementations (#27132) Add note on plugin distributions in plugins folder Remove implementations of `TransportChannel` (#27388) Update Google SDK to version 1.23 (#27381) Fix Gradle 4.3.1 compatibility for logging (#27382) [Test] Change Elasticsearch startup timeout to 120s in packaging tests Docs/windows installer (#27369)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated documentation for the Windows Installer 6.0 release:
@Mpdreamz would you mind specifically double-checking the instructions with regards to
INSTALLDIRfrom the command line?