Skip to content

Adjust assertions for sequence numbers BWC tests#27251

Merged
jasontedor merged 1 commit intoelastic:6.xfrom
jasontedor:smarter-seq-no-bwc
Nov 3, 2017
Merged

Adjust assertions for sequence numbers BWC tests#27251
jasontedor merged 1 commit intoelastic:6.xfrom
jasontedor:smarter-seq-no-bwc

Conversation

@jasontedor
Copy link
Copy Markdown
Member

This commit adjusts the assertions for the sequence number BWC tests to account for the fact that sometimes these tests are run in mixed-clusters with 5.6 nodes (that do not understand sequence numbers), and sometimes these tests are run in mixed-cluster with 6.0+ nodes (that all understood sequence numbers).

This commit adjusts the assertions for the sequence number BWC tests to
account for the fact that sometimes these tests are run in
mixed-clusters with 5.6 nodes (that do not understand sequence numbers),
and sometimes these tests are run in mixed-cluster with 6.0+ nodes (that
all understood sequence numbers).
@jasontedor jasontedor added >test Issues or PRs that are addressing/adding tests v6.1.0 v7.0.0 labels Nov 3, 2017
@jasontedor jasontedor requested a review from martijnvg November 3, 2017 11:45
Copy link
Copy Markdown
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martijnvg
Copy link
Copy Markdown
Member

(test failure looks not related to this change)

@jasontedor jasontedor merged commit d5e56c5 into elastic:6.x Nov 3, 2017
jasontedor added a commit that referenced this pull request Nov 3, 2017
This commit adjusts the assertions for the sequence number BWC tests to
account for the fact that sometimes these tests are run in
mixed-clusters with 5.6 nodes (that do not understand sequence numbers),
and sometimes these tests are run in mixed-cluster with 6.0+ nodes (that
all understood sequence numbers).

Relates #27251
@jasontedor jasontedor deleted the smarter-seq-no-bwc branch November 3, 2017 13:06
DaveCTurner pushed a commit to DaveCTurner/elasticsearch that referenced this pull request Nov 15, 2017
This commit adjusts the assertions for the sequence number BWC tests to
account for the fact that sometimes these tests are run in
mixed-clusters with 5.6 nodes (that do not understand sequence numbers),
and sometimes these tests are run in mixed-cluster with 6.0+ nodes (that
all understood sequence numbers).

Relates elastic#27251
DaveCTurner added a commit that referenced this pull request Nov 15, 2017
An attempt to bump to 6.0.1 on the 6.0 branch exposed up a handful of issues that this commit fixes. One of those fixes is a terrible hack that will be fixed more thoroughly in #27397, and another is a back port of d5e56c5 which is related to #27251.
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Nov 15, 2017
An attempt to bump to 6.0.1 on the 6.0 branch exposed up a handful of issues that this commit fixes. One of those fixes is a terrible hack that will be fixed more thoroughly in elastic#27397, and another is a back port of d5e56c5 which is related to elastic#27251.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>test Issues or PRs that are addressing/adding tests v6.1.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants