Reinstate recommendation for ≥ 3 master-eligible nodes.#27204
Merged
DaveCTurner merged 5 commits intoelastic:masterfrom Nov 3, 2017
Merged
Reinstate recommendation for ≥ 3 master-eligible nodes.#27204DaveCTurner merged 5 commits intoelastic:masterfrom
DaveCTurner merged 5 commits intoelastic:masterfrom
Conversation
In the docs for 1.7 ([doc][doc-1.7], [src][src-1.7]) there was a recommendation for at least 3 master-eligible nodes "in critical clusters" but this was lost when that page was updated in 2.0 ([doc][doc-2.0], [src][src-2.0]). I'd like to reinstate this. [doc-1.7]: https://www.elastic.co/guide/en/elasticsearch/reference/1.7/modules-node.html [src-1.7]: https://github.com/elastic/elasticsearch/blob/2cbaccb2f2a495923bc64447fe3396e0fc58b3d3/docs/reference/modules/node.asciidoc [doc-2.0]: https://www.elastic.co/guide/en/elasticsearch/reference/2.0/modules-node.html#split-brain [src-2.0]: https://github.com/elastic/elasticsearch/blob/4799009ad7ea8f885b6aedc6f62ad61d69e7a40d/docs/reference/modules/node.asciidoc
bleskes
approved these changes
Nov 1, 2017
docs/reference/modules/node.asciidoc
Outdated
|
|
||
| Critical clusters must have at least three master-eligible nodes, with | ||
| `minimum_master_nodes` set accordingly, in order to remain available even when | ||
| a node fails. A <<rolling-upgrades,rolling upgrade>> also requires at least |
Contributor
There was a problem hiding this comment.
can you add "which don't allow any downtime" so it's clear what we're aiming at?
jasontedor
reviewed
Nov 1, 2017
docs/reference/modules/node.asciidoc
Outdated
| ---------------------------- | ||
| <1> Defaults to `1`. | ||
|
|
||
| Critical clusters must have at least three master-eligible nodes, with |
Member
There was a problem hiding this comment.
What is a "critical cluster"? What is "must"? We enforce nothing here, I want to understand where this is going, what is the reason for asserting this?
Member
Author
There was a problem hiding this comment.
The "critical" terminology was lifted from the 1.7 docs, but perhaps something more descriptive would be better. "Highly-available" perhaps?
"Must" is indeed a little strong - how about "should"?
We don't recommend a redundant set of master-eligible nodes (i.e. ≥ 3) anywhere in the docs as far as I can tell, but I feel that should be written down somewhere.
Member
Author
|
@jasontedor Is this better? |
jasontedor
reviewed
Nov 2, 2017
docs/reference/modules/node.asciidoc
Outdated
| ---------------------------- | ||
| <1> Defaults to `1`. | ||
|
|
||
| Clusters should have at least three master-eligible nodes, with |
Member
There was a problem hiding this comment.
Let's start with why we are doing this: In order to be able to remain available... and finish with what should be done. And maybe "to be able" are needless words?
Member
Author
|
@jasontedor sure, I've done that. |
DaveCTurner
added a commit
that referenced
this pull request
Nov 3, 2017
In the docs for 1.7 ([doc][doc-1.7], [src][src-1.7]) there was a recommendation for at least 3 master-eligible nodes "in critical clusters" but this was lost when that page was updated in 2.0 ([doc][doc-2.0], [src][src-2.0]). I'd like to reinstate this. [doc-1.7]: https://www.elastic.co/guide/en/elasticsearch/reference/1.7/modules-node.html [src-1.7]: https://github.com/elastic/elasticsearch/blob/2cbaccb2f2a495923bc64447fe3396e0fc58b3d3/docs/reference/modules/node.asciidoc [doc-2.0]: https://www.elastic.co/guide/en/elasticsearch/reference/2.0/modules-node.html#split-brain [src-2.0]: https://github.com/elastic/elasticsearch/blob/4799009ad7ea8f885b6aedc6f62ad61d69e7a40d/docs/reference/modules/node.asciidoc
Member
Author
|
Merged into master and backported to 6.x as b2c7471. |
Member
|
@DaveCTurner I think this can go back to the 5.6 and 6.0 branches as well. |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 3, 2017
In the docs for 1.7 ([doc][doc-1.7], [src][src-1.7]) there was a recommendation for at least 3 master-eligible nodes "in critical clusters" but this was lost when that page was updated in 2.0 ([doc][doc-2.0], [src][src-2.0]). I'd like to reinstate this. [doc-1.7]: https://www.elastic.co/guide/en/elasticsearch/reference/1.7/modules-node.html [src-1.7]: https://github.com/elastic/elasticsearch/blob/2cbaccb2f2a495923bc64447fe3396e0fc58b3d3/docs/reference/modules/node.asciidoc [doc-2.0]: https://www.elastic.co/guide/en/elasticsearch/reference/2.0/modules-node.html#split-brain [src-2.0]: https://github.com/elastic/elasticsearch/blob/4799009ad7ea8f885b6aedc6f62ad61d69e7a40d/docs/reference/modules/node.asciidoc
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 3, 2017
In the docs for 1.7 ([doc][doc-1.7], [src][src-1.7]) there was a recommendation for at least 3 master-eligible nodes "in critical clusters" but this was lost when that page was updated in 2.0 ([doc][doc-2.0], [src][src-2.0]). I'd like to reinstate this. [doc-1.7]: https://www.elastic.co/guide/en/elasticsearch/reference/1.7/modules-node.html [src-1.7]: https://github.com/elastic/elasticsearch/blob/2cbaccb2f2a495923bc64447fe3396e0fc58b3d3/docs/reference/modules/node.asciidoc [doc-2.0]: https://www.elastic.co/guide/en/elasticsearch/reference/2.0/modules-node.html#split-brain [src-2.0]: https://github.com/elastic/elasticsearch/blob/4799009ad7ea8f885b6aedc6f62ad61d69e7a40d/docs/reference/modules/node.asciidoc
Member
Author
martijnvg
added a commit
that referenced
this pull request
Nov 4, 2017
* es/master: Fix snapshot getting stuck in INIT state (#27214) Add an example of dynamic field names (#27255) #26260 Allow ip_range to accept CIDR notation (#27192) #27189 Fixed rounding of bounds in scaled float comparison (#27207) Add support for Gradle 4.3 (#27249) Fixes QueryStringQueryBuilderTests build: Fix setting the incorrect bwc version in mixed cluster qa module [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery BWC Adjust assertions for sequence numbers BWC tests Do not create directories if repository is readonly (#26909) [Test] Fix InternalStatsTests [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery Uses norms for exists query if enabled (#27237) Reinstate recommendation for ≥ 3 master-eligible nodes. (#27204)
martijnvg
added a commit
that referenced
this pull request
Nov 4, 2017
* 6.x: Add an example of dynamic field names (#27255) fixed checkstyle violation #26260 Allow ip_range to accept CIDR notation (#27192) #27189 Fixed rounding of bounds in scaled float comparison (#27207) [TEST] Fix failing exists query test test: Do not run old parent/child tests against a cluster with minimum version greater than 6.0.0 Add support for Gradle 4.3 (#27249) Fixes QueryStringQueryBuilderTests build: Fix setting the incorrect bwc version in mixed cluster qa module fix compil after backport [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery BWC Adjust assertions for sequence numbers BWC tests Do not create directories if repository is readonly (#26909) [Test] Fix QueryStringQueryBuilderTests.testExistsFieldQuery Uses norms for exists query if enabled (#27237) Reinstate recommendation for ≥ 3 master-eligible nodes. (#27204)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the docs for 1.7 (doc, src) there was a recommendation for at least 3 master-eligible nodes "in critical clusters" but this was lost when that page was updated in 2.0 (doc, src). I'd like to reinstate this.