Added clarification on interaction with create index api#26994
Merged
jasontedor merged 2 commits intomasterfrom Oct 12, 2017
Merged
Added clarification on interaction with create index api#26994jasontedor merged 2 commits intomasterfrom
jasontedor merged 2 commits intomasterfrom
Conversation
jasontedor
requested changes
Oct 12, 2017
|
|
||
| NOTE: Templates are only applied at index creation time. Changing a template | ||
| will have no impact on existing indices. | ||
| will have no impact on existing indices. When using the create index api, the settings/mappings |
Member
There was a problem hiding this comment.
Would you capitalize API please?
jasontedor
pushed a commit
that referenced
this pull request
Oct 12, 2017
This commit clarifies the interaction between settings specified in a create index request, and those that would come from any templates that apply to the create index request. Relates #26994
jasontedor
pushed a commit
that referenced
this pull request
Oct 12, 2017
This commit clarifies the interaction between settings specified in a create index request, and those that would come from any templates that apply to the create index request. Relates #26994
jasontedor
pushed a commit
that referenced
this pull request
Oct 12, 2017
This commit clarifies the interaction between settings specified in a create index request, and those that would come from any templates that apply to the create index request. Relates #26994
Member
|
Thanks so much @ppf2. I merged and backported and added labels. |
Contributor
Author
|
Thx for the review+merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users are not expecting create index api settings/mappings to take precedence over index template. This is added to clarify the behavior.