Simplify Azure blobStore method signatures#26752
Merged
dadoonet merged 5 commits intoelastic:masterfrom Oct 4, 2017
Merged
Conversation
While working on elastic#26751, I found that we are passing the container name on every single method although we don't need it as it is stored within the blobstore object already. This PR simplifies a bit that part of the code.
imotov
approved these changes
Sep 22, 2017
| } | ||
|
|
||
| public void deleteFiles(String container, String path) throws URISyntaxException, StorageException | ||
| public void deleteFiles(String path) throws URISyntaxException, StorageException |
Contributor
There was a problem hiding this comment.
I don't think this method is used anymore. So, maybe you should clean it up as well while you are at it.
# Conflicts: # plugins/repository-azure/src/main/java/org/elasticsearch/repositories/azure/AzureBlobContainer.java # plugins/repository-azure/src/main/java/org/elasticsearch/repositories/azure/AzureBlobStore.java
Was not used anymore. Also move some properties in AzureBlobContainer to `private` members.
Contributor
Author
|
@elasticmachine test it please |
dadoonet
added a commit
that referenced
this pull request
Oct 4, 2017
While working on #26751, I found that we are passing the container name on every single method although we don't need it as it is stored within the blobstore object already. This commit simplifies a bit that part of the code. It also removes `repositoryName` from AzureBlobStore which was not used anymore. Also we move some properties in AzureBlobContainer to `private` members. Backport of #26752 in 6.x branch
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #26751, I found that we are passing the container name on every single method although we don't need it as it is stored within the blobstore object already.
This PR simplifies a bit that part of the code.