Add azure storage endpoint suffix #26432#26568
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
|
||
| /** | ||
| * Azure endpoint suffix. Default to core.windows.net (CloudStorageAccount.DEFAULT_DNS). | ||
| */ |
There was a problem hiding this comment.
Why does this need to be a secure setting?
There was a problem hiding this comment.
Thanks! I think a normal string is OK. Shall I merge with master for review?
| /** | ||
| * Azure endpoint suffix. Default to core.windows.net (CloudStorageAccount.DEFAULT_DNS). | ||
| */ | ||
| public static final Setting<String> ENDPOINT_SUFFIX_SETTING = Setting.affixKeySetting(PREFIX, "endpoint_suffix", |
There was a problem hiding this comment.
I don't think the endpoint needs to be a secure setting.
|
@jasontedor @rjernst I updated the PR, please review again. Thanks! |
|
@elasticmachine please test this |
|
@elasticmachine test this |
|
@rjernst Thanks, I think the testing errors are not caused by my changes... |
|
@elasticmachine retest this please |
|
I tested this locally. Looks good, thanks @liketic! |
* master: Add permission checks before reading from HDFS stream (elastic#26716) muted test [Docs] Fixed typo of *configuration* (elastic#25058) Add azure storage endpoint suffix elastic#26432 (elastic#26568)
Close #26432
Happy to hear any comments to make this PR better. Thanks in advance. 😄