Add bad_request to the rest-api-spec catch params#26539
Add bad_request to the rest-api-spec catch params#26539hub-cap merged 10 commits intoelastic:masterfrom
Conversation
This adds another request to the catch params. It also makes sure that the generic request param does not allow 400 either.
|
Please note I did not change the lower bounds on the generic |
jasontedor
left a comment
There was a problem hiding this comment.
LGTM assuming that @elastic/es-clients is good with the addition.
|
Yes, I prefer the way that you've done it here. |
|
@elasticmachine test this please for some reason I dont see the integration for CI on this PR anymore?
|
|
You might consider adding a "feature skip" to these tests, otherwise every client is going to get whacked with 20+ failures until client authors can update their test runner. E.g. - skip:
features: bad_requestI guess it depends how urgently you want client authors to update. Skip == when they get a chance, no skip == lotsa failures == asap. |
|
oh my. Thats not good. Let me sync w/ the client team and see how they would like to proceed. Id love to not break builds for them. Ty for the heads up @polyfractal |
|
OTOH, I think most of the client team uses breakages as a signal that something needs updating. It's easier than trying to closely track upstream changes (and we're lazy) :) I'm ++ on the |
|
@hub-cap informed the #lang-clients room and @polyfractal raised the possible breakage during the last clients meeting which did not seem to rattle anyone 😄. I feel enough time has passed for anyone from @elastic/es-clients to object to the breakage. |
|
@elasticmachine test this please |
This adds another request to the catch params. It also makes sure that the generic request param does not allow 400 either.
This adds another request to the catch params. It also makes sure that the generic request param does not allow 400 either.
* master: fix testSniffNodes to use the new error message Add check for invalid index in WildcardExpressionResolver (elastic#26409) Docs: Use single-node discovery.type for dev example Filter unsupported relation for range query builder (elastic#26620) Fix kuromoji default stoptags (elastic#26600) [Docs] Add description for missing fields in Reindex/Update/Delete By Query (elastic#26618) [Docs] Update ingest.asciidoc (elastic#26599) Better message text for ResponseException [DOCS] Remove edit link from ML node enable bwc testing fix StartRecoveryRequestTests.testSerialization Add bad_request to the rest-api-spec catch params (elastic#26539) Introduce a History UUID as a requirement for ops based recovery (elastic#26577) Add missing catch arguments to the rest api spec (elastic#26536)
This adds another request to the catch params. It also makes sure that
the generic request param does not allow 400 either.