Move generic http settings out of netty module#26310
Merged
Tim-Brooks merged 1 commit intoelastic:masterfrom Aug 25, 2017
Merged
Move generic http settings out of netty module#26310Tim-Brooks merged 1 commit intoelastic:masterfrom
Tim-Brooks merged 1 commit intoelastic:masterfrom
Conversation
There is a group of five settings relating to raw tcp configurations (no_delay, buffer sizes, etc) that we have for the http transport. These currently live in the netty module. As they are unrelated to netty specifically, this commit moves these settings to the `HttpTransportSettings` class in core.
Contributor
Author
|
Thanks for the review @jasontedor |
Tim-Brooks
added a commit
that referenced
this pull request
Aug 25, 2017
There is a group of five settings relating to raw tcp configurations (no_delay, buffer sizes, etc) that we have for the http transport. These currently live in the netty module. As they are unrelated to netty specifically, this commit moves these settings to the `HttpTransportSettings` class in core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a group of five settings relating to raw tcp configurations
(no_delay, buffer sizes, etc) that we have for the http transport. These
currently live in the netty module. As they are unrelated to netty
specifically, this commit moves these settings to the
HttpTransportSettingsclass in core.