Skip to content

Add packaging test for systemd runtime directive#26229

Merged
jasontedor merged 2 commits intoelastic:masterfrom
jasontedor:systemd-runtime-directory
Aug 16, 2017
Merged

Add packaging test for systemd runtime directive#26229
jasontedor merged 2 commits intoelastic:masterfrom
jasontedor:systemd-runtime-directory

Conversation

@jasontedor
Copy link
Copy Markdown
Member

We previously added a RuntimeDirectory directive to the systemd service file for Elasticsearch. This commit adds a packaging test for the situation that this directive was intended to address.

Relates #23526

We previously added a RuntimeDirectory directive to the systemd service
file for Elasticsearch. This commit adds a packaging test for the
situation that this directive was intended to address.
@jasontedor jasontedor added :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts review >test Issues or PRs that are addressing/adding tests v6.0.0 v6.1.0 v7.0.0 labels Aug 16, 2017
@jasontedor jasontedor requested a review from dakrone August 16, 2017 02:25
Copy link
Copy Markdown
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a minor suggestion

install_package
sudo rm -rf /var/run/elasticsearch
systemctl start elasticsearch.service
wait_for_elasticsearch_status
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also check that the directory has been correctly created

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion; I pushed a check in 7c83a2f.

@tlrx
Copy link
Copy Markdown
Member

tlrx commented Aug 16, 2017

(And thanks for adding this test)

@jasontedor jasontedor merged commit 7fb9105 into elastic:master Aug 16, 2017
jasontedor added a commit that referenced this pull request Aug 16, 2017
We previously added a RuntimeDirectory directive to the systemd service
file for Elasticsearch. This commit adds a packaging test for the
situation that this directive was intended to address.

Relates #26229
jasontedor added a commit that referenced this pull request Aug 16, 2017
We previously added a RuntimeDirectory directive to the systemd service
file for Elasticsearch. This commit adds a packaging test for the
situation that this directive was intended to address.

Relates #26229
@jasontedor jasontedor deleted the systemd-runtime-directory branch August 16, 2017 08:38
@lcawl lcawl removed the v6.1.0 label Dec 12, 2017
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v6.0.0-beta2 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants