When putHeaders, Order problem.#26037
Closed
hanbj wants to merge 10 commits intoelastic:masterfrom
hanbj:master
Closed
When putHeaders, Order problem.#26037hanbj wants to merge 10 commits intoelastic:masterfrom hanbj:master
hanbj wants to merge 10 commits intoelastic:masterfrom
hanbj:master
Conversation
# Conflicts: # modules/transport-netty4/src/main/java/org/elasticsearch/transport/netty4/Netty4Transport.java
Updated in August 2, 2017
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
Contributor
|
Hi @hanbj , may I ask how you found out about this? Was this a problem that you ran into or something that you noticed while looking at the code? |
Contributor
|
jenkins test this please |
Contributor
Author
|
@javanna Thank you for verifying the patch, I found this when I read the code |
Contributor
Author
|
@karmi I'm sure I've always used this email on GitHub. How can I have a different signature? |
merge remote on 2017.08.04
Contributor
Author
Contributor
Contributor
Author
|
@karmi OK, Thanks. I resubmit it. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1、The parameter headers does not have the same key, so the checksum doesn't make sense
2、When checking that key already exists in requestHeaders, you should first put