Skip to content

When putHeaders, Order problem.#26037

Closed
hanbj wants to merge 10 commits intoelastic:masterfrom
hanbj:master
Closed

When putHeaders, Order problem.#26037
hanbj wants to merge 10 commits intoelastic:masterfrom
hanbj:master

Conversation

@hanbj
Copy link
Copy Markdown
Contributor

@hanbj hanbj commented Aug 3, 2017

1、The parameter headers does not have the same key, so the checksum doesn't make sense
2、When checking that key already exists in requestHeaders, you should first put

@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@karmi
Copy link
Copy Markdown
Contributor

karmi commented Aug 3, 2017

Hi @hanbj, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@javanna
Copy link
Copy Markdown
Contributor

javanna commented Aug 3, 2017

Hi @hanbj , may I ask how you found out about this? Was this a problem that you ran into or something that you noticed while looking at the code?

@javanna
Copy link
Copy Markdown
Contributor

javanna commented Aug 3, 2017

jenkins test this please

@hanbj
Copy link
Copy Markdown
Contributor Author

hanbj commented Aug 4, 2017

@javanna Thank you for verifying the patch, I found this when I read the code

@hanbj
Copy link
Copy Markdown
Contributor Author

hanbj commented Aug 4, 2017

@karmi I'm sure I've always used this email on GitHub. How can I have a different signature?

@hanbj
Copy link
Copy Markdown
Contributor Author

hanbj commented Aug 4, 2017

(1018a11)
@javanna Accidentally put together, please test together, thank you.
When you build the FixedExecutorBuilder instance, the parameter availableProcessors is passed in the construction method. Therefore, there is no need to calculate once in the applyHardSizeLimit() method

@karmi
Copy link
Copy Markdown
Contributor

karmi commented Aug 5, 2017

@hanbj, this commit was failing the check, dbd6206

I think you should git rebase instead of merge the upstream commits, that way the PR is cleaner to read...

@hanbj
Copy link
Copy Markdown
Contributor Author

hanbj commented Aug 5, 2017

@karmi OK, Thanks. I resubmit it.

@hanbj hanbj closed this Aug 5, 2017
@hanbj
Copy link
Copy Markdown
Contributor Author

hanbj commented Aug 5, 2017

#26070 #26068
@karmi I'm sorry to trouble you. I resubmit it. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants