Calculate once the number of machine cores#26070
Closed
hanbj wants to merge 1 commit intoelastic:masterfrom
hanbj:threadpool
Closed
Calculate once the number of machine cores#26070hanbj wants to merge 1 commit intoelastic:masterfrom hanbj:threadpool
hanbj wants to merge 1 commit intoelastic:masterfrom
hanbj:threadpool
Conversation
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Member
|
This code should remain as-is. It's clearer this way, and it does not rely on the defaults being equal to the number of available processors. |
Contributor
Author
|
@jasontedor Thank you for your review. Please review the #26068. I'm sure it has a logical problem. Thank you. |
Member
|
@hanbj I think that it's already getting attention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1、When building the FixedExecutorBuilder and AutoQueueAdjustingExecutorBuilder instance, the parameter availableProcessors is passed in the construction method.
2、numberOfProcessors: There is no need to calculate the number of machine cores again.