Skip to content

Caching a MinDocQuery can lead to wrong results.#25909

Merged
jpountz merged 2 commits intoelastic:masterfrom
jpountz:fix/min_doc_query_caching
Jul 27, 2017
Merged

Caching a MinDocQuery can lead to wrong results.#25909
jpountz merged 2 commits intoelastic:masterfrom
jpountz:fix/min_doc_query_caching

Conversation

@jpountz
Copy link
Copy Markdown
Contributor

@jpountz jpountz commented Jul 26, 2017

Queries are supposed to be cacheable per segment, yet matches of this query
also depend on how many documents exist on previous segments.

Queries are supposed to be cacheable per segment, yet matches of this query
also depend on how many documents exist on previous segments.
@jpountz jpountz added :Search/Search Search-related issues that do not fall into other categories >bug labels Jul 26, 2017
@jpountz jpountz requested a review from jimczi July 26, 2017 14:22
Copy link
Copy Markdown
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks !

@jpountz jpountz merged commit 1cd5e34 into elastic:master Jul 27, 2017
@jpountz jpountz deleted the fix/min_doc_query_caching branch July 27, 2017 09:19
jpountz added a commit that referenced this pull request Jul 27, 2017
Queries are supposed to be cacheable per segment, yet matches of this query
also depend on how many documents exist on previous segments.
jpountz added a commit that referenced this pull request Jul 27, 2017
Queries are supposed to be cacheable per segment, yet matches of this query
also depend on how many documents exist on previous segments.
jpountz added a commit that referenced this pull request Jul 27, 2017
Queries are supposed to be cacheable per segment, yet matches of this query
also depend on how many documents exist on previous segments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Search/Search Search-related issues that do not fall into other categories v5.6.0 v6.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants