[DOCS] Update shared attributes for Elasticsearch#25479
Merged
lcawl merged 3 commits intoelastic:masterfrom Jun 29, 2017
Merged
[DOCS] Update shared attributes for Elasticsearch#25479lcawl merged 3 commits intoelastic:masterfrom
lcawl merged 3 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
@debadair If we eventually want to use the shared attributes from books other than the Elasticsearch Reference (e.g. from the Painless and client books), we can move the "include::{docs-dir}/shared/attributes.asciidoc[]" from index-shared1.asciidoc to Versions.asciidoc. I haven't done any work on those other books at this point. |
debadair
reviewed
Jun 29, 2017
Contributor
|
BTW, I'd be inclined to pull the attributes for the definitive guide and painless and plugins docs into the shared file, as well. |
20f4f2e to
0614e25
Compare
0614e25 to
95926c0
Compare
Contributor
Author
|
@debadair verified that the other books were okay to use the shared attributes, so I moved the reference to the elastic/docs/shared/attributes.asciidoc from index-shared1.asciidoc to Versions.asciidoc. I also moved the definitive guide, painless, and plugins doc URLs to the shared file too. |
Contributor
|
LGTM |
lcawl
added a commit
that referenced
this pull request
Jun 29, 2017
* [DOCS] Update shared attributes for Elasticsearch * [DOCS] Moved shared attributes to Versions.asciidoc * [DOCS] More more book URLs to shared attributes
lcawl
added a commit
that referenced
this pull request
Jun 29, 2017
* [DOCS] Update shared attributes for Elasticsearch * [DOCS] Moved shared attributes to Versions.asciidoc * [DOCS] More more book URLs to shared attributes
Contributor
Author
|
Thanks! I've retrofitted to 5.x and 5.5 |
jasontedor
added a commit
that referenced
this pull request
Jun 30, 2017
* master: (129 commits) Add doc note regarding explicit publish host Fix typo in name of test Add additional test for sequence-number recovery WrapperQueryBuilder should also rewrite the parsed query. Remove dead code and stale Javadoc Update defaults in documentation (#25483) [DOCS] Add docs-dir to Painless (#25482) Add concurrent deprecation logger test [DOCS] Update shared attributes for Elasticsearch (#25479) Use LRU set to reduce repeat deprecation messages Add NioTransport threads to thread name checks (#25477) Add shortcut for AbstractQueryBuilder.parseInnerQueryBuilder to QueryShardContext Prevent channel enqueue after selector close (#25478) Fix Java 9 compilation issue Remove unregistered `transport.netty.*` settings (#25476) Handle ping correctly in NioTransport (#25462) Tests: Remove platform specific assertion in NioSocketChannelTests Remove QueryParseContext from parsing QueryBuilders (#25448) Promote replica on the highest version node (#25277) test: added not null assertion ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes shared attributes from the Versions.asciidoc file and instead adds a reference to the list of shared attributes in the elastic/docs/shared repository.