Adapt SearchIT#testSearchWithParentJoin to new join field#25379
Merged
cbuescher merged 1 commit intoelastic:masterfrom Jun 23, 2017
Merged
Adapt SearchIT#testSearchWithParentJoin to new join field#25379cbuescher merged 1 commit intoelastic:masterfrom
SearchIT#testSearchWithParentJoin to new join field#25379cbuescher merged 1 commit intoelastic:masterfrom
Conversation
In order to remove changing the "index.mapping.single_type" setting in this test we need to change it to use the new join field. Closes elastic#25372
dengm129
approved these changes
Jun 23, 2017
nik9000
approved these changes
Jun 23, 2017
Member
Author
|
Thanks @martijnvg and @nik9000 |
Contributor
|
awesome! thanks @cbuescher |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jun 26, 2017
* master: Move more token filters to analysis-common module Test: Allow merging mock secure settings (elastic#25387) Remove remaining `index.mapper.single_type` setting usage from tests (elastic#25388) Remove dead logger prefix code Tests: Improve stability and logging of TemplateUpgradeServiceIT tests (elastic#25386) Remove `index.mapping.single_type=false` from reindex tests (elastic#25365) Adapt `SearchIT#testSearchWithParentJoin` to new join field (elastic#25379) Added unit test coverage for SignificantTerms (elastic#24904)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to remove changing the "index.mapping.single_type" setting in this test
we need to change it to use the new join field.
Closes #25372