Internal: Remove Strings.cleanPath#25209
Merged
rjernst merged 3 commits intoelastic:masterfrom Jun 14, 2017
Merged
Conversation
This commit removes the cleanPath method, in favor of using java's Path.normalize().
This was referenced Jun 13, 2017
jasontedor
approved these changes
Jun 14, 2017
Member
jasontedor
left a comment
There was a problem hiding this comment.
I left one comment. Another is that there is a behavior difference between Strings#cleanPath and Path#normalize; namely the former was converting Windows folder separators to Unix folder separators. I do not think that should matter anywhere (if it did, we can fix it), just something to keep in mind. I'm glad to see this method gone, it never made sense, especially living in org.elasticsearch.common.Strings.
| for (int i = 0; i < tops; i++) { | ||
| pathElements.add(0, TOP_PATH); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I think that FOLDER_SEPARATOR and WINDOWS_FOLDER_SEPARATOR are dead fields now?
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jun 14, 2017
* master: (27 commits) Refactor TransportShardBulkAction.executeUpdateRequest and add tests Make sure range queries are correctly profiled. (elastic#25108) Test: allow setting socket timeout for rest client (elastic#25221) Migration docs for elastic#25080 (elastic#25218) Remove `discovery.type` BWC layer from the EC2/Azure/GCE plugins elastic#25080 When stopping via systemd only kill the JVM, not its control group (elastic#25195) Remove PrefixAnalyzer, because it is no longer used. Internal: Remove Strings.cleanPath (elastic#25209) Docs: Add note about which secure settings are valid (elastic#25212) Indices.rollover/10_basic should refresh to make the doc visible in lucene stats Port support for commercial GeoIP2 databases from Logstash. (elastic#24889) [DOCS] Add ML node to node.asciidoc (elastic#24495) expose simple pattern tokenizers (elastic#25159) Test: add setting to change request timeout for rest client (elastic#25201) Fix secure repository-hdfs tests on JDK 9 Add target_field parameter to gsub, join, lowercase, sort, split, trim, uppercase (elastic#24133) Add Cross Cluster Search support for scroll searches (elastic#25094) Adapt skip version in rest-api-spec/test/indices.rollover/20_max_doc_condition.yml Rollover max docs should only count primaries (elastic#24977) Add remote cluster infrastructure to fetch discovery nodes. (elastic#25123) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the cleanPath method, in favor of using java's
Path.normalize().