Extract the snapshot/restore full cluster restart tests from the translog full cluster restart tests#25204
Conversation
imotov
left a comment
There was a problem hiding this comment.
The snapshot test fails because we wipe out all snapshots at the end of the test. While preserveReposUponCompletion() preserves the repository themselves the repository end up with all snapshots deleted in it. After I commented out the wipeSnapshots method call the test passed. It looks like we need another preserveSnapshotsUponCompletion() flag that will preserve both repos and snapshots in them.
|
Thanks @imotov! I'm fixing it now. |
Did `git add .` in the wrong dir..... Silly me!
imotov
left a comment
There was a problem hiding this comment.
I am just wondering who is going to clean the snapshots after the test and shouldn't preserveSnapshotsUponCompletion() and preserveReposUponCompletion() can be something like runningAgainstOldCluster == false instead of always be true? Otherwise LGTM.
I think it has to stay true the whole time because the wipe is done after every test rather than after the whole suite. The snapshots aren't cleaned up by the test at all - we leave them until either |
|
@nik9000 yep, good point. |
* master: Upgrade icu4j for the ICU analysis plugin to 59.1 (elastic#25243) move assertBusy to use CheckException (elastic#25246) Use SPI in High Level Rest Client to load XContent parsers (elastic#25098) [TEST] test that low level REST client leaves path untouched (elastic#25193) Speed up PK lookups at index time. (elastic#19856) [Docs] Fix documentation for percentiles bucket aggregation (elastic#25229) Upgrade to lucene-7.0.0-snapshot-92b1783. (elastic#25222) Build: Add master flag for disabling bwc tests (elastic#25230) Scripting: Rename SearchScript.needsScores to needs_score (elastic#25235) Support script context stateful factory in Painless. (elastic#25233) FastVectorHighlighter should not cache the field query globally (elastic#25197) Remove QUERY_AND_FETCH BWC for pre-5.3.0 nodes (elastic#25223) Add more missing AggregationBuilder getters (elastic#25198) Extract the snapshot/restore full cluster restart tests from the translog full cluster restart tests (elastic#25204)
* master: (44 commits) Upgrade icu4j for the ICU analysis plugin to 59.1 (elastic#25243) move assertBusy to use CheckException (elastic#25246) Use SPI in High Level Rest Client to load XContent parsers (elastic#25098) [TEST] test that low level REST client leaves path untouched (elastic#25193) Speed up PK lookups at index time. (elastic#19856) [Docs] Fix documentation for percentiles bucket aggregation (elastic#25229) Upgrade to lucene-7.0.0-snapshot-92b1783. (elastic#25222) Build: Add master flag for disabling bwc tests (elastic#25230) Scripting: Rename SearchScript.needsScores to needs_score (elastic#25235) Support script context stateful factory in Painless. (elastic#25233) FastVectorHighlighter should not cache the field query globally (elastic#25197) Remove QUERY_AND_FETCH BWC for pre-5.3.0 nodes (elastic#25223) Add more missing AggregationBuilder getters (elastic#25198) Extract the snapshot/restore full cluster restart tests from the translog full cluster restart tests (elastic#25204) Refactor TransportShardBulkAction.executeUpdateRequest and add tests Make sure range queries are correctly profiled. (elastic#25108) Test: allow setting socket timeout for rest client (elastic#25221) Migration docs for elastic#25080 (elastic#25218) Remove `discovery.type` BWC layer from the EC2/Azure/GCE plugins elastic#25080 When stopping via systemd only kill the JVM, not its control group (elastic#25195) ...
Extract the snapshot/restore full cluster restart tests from the translog full cluster restart tests. That way they are easier to read.
Closes #25203