[Tests] Check Suggestion parsers robustness for new fields#25132
Merged
cbuescher merged 1 commit intoelastic:masterfrom Jun 9, 2017
Merged
[Tests] Check Suggestion parsers robustness for new fields#25132cbuescher merged 1 commit intoelastic:masterfrom
cbuescher merged 1 commit intoelastic:masterfrom
Conversation
cbuescher
commented
Jun 8, 2017
| XContentType xContentType = randomFrom(XContentType.values()); | ||
| boolean humanReadable = randomBoolean(); | ||
| BytesReference originalBytes = toXContent(suggest, xContentType, params, humanReadable); | ||
| BytesReference originalBytes = toShuffledXContent(suggest, xContentType, params, humanReadable); |
Member
Author
There was a problem hiding this comment.
Note: this test doesn't need any field randomization I think. The suggest element is a object containing names Suggestions, which we already test elsewhere. I think it is not possible that we add anything other inside this object unless we change the whole structure of the xContent (which is another story).
tlrx
approved these changes
Jun 8, 2017
| if (addRandomFields) { | ||
| // - "contexts" is an object consisting of key/array pairs, we shouldn't add anything random there | ||
| // - there can be inner search hits fields inside this option where we cannot add random stuff | ||
| // - the root object should be excluded since it contains the named suggestion arrays |
cbuescher
added a commit
that referenced
this pull request
Jun 9, 2017
When parsing responses we should be ignoring any new unknown fields or inner objects in most cases to be forward compatible with changes in core on the client side. This change adds test for this for Suggestions and its various subclasses to check if we are able to ignore new fields and objects in the xContent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing resonses we should be ignoring any new unknown fields or inner objects in most cases to be forward compatible with changes in core on the
client side. This change adds test for this for Suggestions and its various subclasses to check if we are able to ignore new fields and objects in the xContent.