[Tests] Check QueryProfileShardResult parser robustness for new fields#25130
Merged
cbuescher merged 2 commits intoelastic:masterfrom Jun 8, 2017
Merged
[Tests] Check QueryProfileShardResult parser robustness for new fields#25130cbuescher merged 2 commits intoelastic:masterfrom
cbuescher merged 2 commits intoelastic:masterfrom
Conversation
tlrx
approved these changes
Jun 8, 2017
| ensureExpectedToken(XContentParser.Token.START_ARRAY, parser.nextToken(), parser::getTokenLocation); | ||
| while((token = parser.nextToken()) != XContentParser.Token.END_ARRAY) { | ||
| parseSearchProfileResultsEntry(parser, searchProfileResults); | ||
| ensureExpectedToken(XContentParser.Token.START_OBJECT, token, parser::getTokenLocation); |
Member
There was a problem hiding this comment.
nit: we can check the expected token and then create the searchProfileResults map
| } | ||
|
|
||
| public void testFromXContent() throws IOException { | ||
| dofromXContentTestWithRandomFields(false); |
Member
There was a problem hiding this comment.
nit: doFromXContentTestWithRandomFields
| } | ||
|
|
||
| public void testFromXContent() throws IOException { | ||
| dofromXContentTestWithRandomFields(false); |
Member
There was a problem hiding this comment.
nit: doFromXContentTestWithRandomFields
6ddc312 to
18dd032
Compare
cbuescher
added a commit
that referenced
this pull request
Jun 8, 2017
#25130) When parsing resonses we should be ignoring any new unknown fields or inner objects in most cases to be forward compatible with changes in core on the client side. This change adds test for this for QueryProfileShardResult and nested substructures and changes the parsing code where necessary to be able to ignore new fields and objects in the xContent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing resonses we should be ignoring any new unknown fields or inner objects in most cases to be forward compatible with changes in core on the
client side. This change adds test for this for QueryProfileShardResult and nested substructures and changes the parsing code where necessary to be able to
ignore new fields and objects in the xContent.