Return index name and empty map for /{index}/_alias with no aliases#25114
Merged
dakrone merged 1 commit intoelastic:masterfrom Jun 8, 2017
Merged
Return index name and empty map for /{index}/_alias with no aliases#25114dakrone merged 1 commit intoelastic:masterfrom
dakrone merged 1 commit intoelastic:masterfrom
Conversation
Member
|
I skimmed the code, the solution looks good to me. However I think we need a REST test here, having a REST test already would have prevented the temporary (unreleased) breakage so I think we should at least add one now? I'm happy to give a full review when that's added. |
Member
Author
|
Thanks for taking a look @jasontedor, I pushed a commit that adds a REST test |
jasontedor
approved these changes
Jun 8, 2017
Member
jasontedor
left a comment
There was a problem hiding this comment.
LGTM. I left one more comment, you can address and fire at will.
Member
There was a problem hiding this comment.
Can you clarify this comment? Something like the list corresponding to a concrete index will be empty if no aliases are present for that index?
Previously in elastic#24723 we changed the `_alias` API to not go through the `RestGetIndicesAction` endpoint, instead creating a `RestGetAliasesAction` that did the same thing. This changes the formatting so that it matches the old formatting of the endpoint, before: ``` GET /test-1/_alias { } ``` And after this change: ``` GET /test-1/_alias { "test-1": { "aliases": {} } } ``` This is related to elastic#25090
7714e97 to
5b2ab96
Compare
Member
Author
|
Thanks @jasontedor! |
This was referenced Jun 8, 2017
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
May 23, 2018
These additional tests were previously reverted in 6.x due to failing bwc tests. They should be skipped against 5.6 nodes, bwc tests fail when the node hit by the request is on 5.6. Relates to elastic#29513 Relates to elastic#25114 Closes elastic#30806
javanna
added a commit
that referenced
this pull request
May 24, 2018
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Jun 18, 2018
Some recent failures on the mixed cluster tests were caused by elastic#31308. Instead of executing get index API when calling GET /_alias we now go through the get alias API. The behaviour of such API is slightly different on 5.6 compared to 6.x and master as to whether indices that have no aliases are returned or not. In fact elastic#25114 was not backported to 5.6. When the 5.6 node is the elected master, if the get alias API goes through such node or another 5.x node, the get index API will be used internally and all tests are fine. If some 6.x node is hit though by the client request, we will go through the get alias API, but we will do it through the elected master which will not return indices without aliases (at transport, see MetaData#findAliases on 5.6). That means that in a mixed cluster this API will return a different result depending on which node is the elected master and which one is hit by the request.
javanna
added a commit
that referenced
this pull request
Jun 19, 2018
Some recent failures on the mixed cluster tests were caused by #31308. Instead of executing get index API when calling GET /_alias we now go through the get alias API. The behaviour of such API is slightly different on 5.6 compared to 6.x and master as to whether indices that have no aliases are returned or not. In fact #25114 was not backported to 5.6. When the 5.6 node is the elected master, if the get alias API goes through such node or another 5.x node, the get index API will be used internally and all tests are fine. If some 6.x node is hit though by the client request, we will go through the get alias API, but we will do it through the elected master which will not return indices without aliases (at transport, see MetaData#findAliases on 5.6). That means that in a mixed cluster this API will return a different result depending on which node is the elected master and which one is hit by the request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in #24723 we changed the
_aliasAPI to not go through theRestGetIndicesActionendpoint, instead creating aRestGetAliasesActionthatdid the same thing.
This changes the formatting so that it matches the old formatting of the
endpoint, before:
And after this change:
This is related to #25090