Use SPI in High Level Rest Client to load XContent parsers#25097
Closed
tlrx wants to merge 1 commit intoelastic:masterfrom
Closed
Use SPI in High Level Rest Client to load XContent parsers#25097tlrx wants to merge 1 commit intoelastic:masterfrom
tlrx wants to merge 1 commit intoelastic:masterfrom
Conversation
The High Level REST Client can use Java's SPI to load named XContent parsers implementations provided by plugins or modules.
This was referenced Jun 7, 2017
Member
Author
|
Superseded by #25098 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new
NamedXContentProviderinterface to core that can be implemented by plugins in order to provide a list of named XContent parsers implementations to external applications (like the High Level REST Client) using the Java Service Provider Interface.This pull request uses Java's SPI as a alternate mechanism to
PluginServicein order to provide named XContent parsers to the High Level REST Client as suggested by @rjernst in #25024 (comment).For now services files are static but they could be generated by Gradle.