_nodes/stats should not fail due to concurrent AlreadyClosedException#25016
Merged
pickypg merged 2 commits intoelastic:masterfrom Jun 28, 2017
Merged
_nodes/stats should not fail due to concurrent AlreadyClosedException#25016pickypg merged 2 commits intoelastic:masterfrom
pickypg merged 2 commits intoelastic:masterfrom
Conversation
Member
Author
|
please test this |
bleskes
approved these changes
Jun 2, 2017
Contributor
bleskes
left a comment
There was a problem hiding this comment.
Code is good. Any chance we can have a test for this?
Member
Author
|
@bleskes I'll refactor the method so that one exists that accepts the iterator for the |
Contributor
|
@pickypg where do we stand on this one? |
This catches `AlreadyClosedException` during `stats` calls to avoid failing a `_nodes/stats` request because of the ignorable, concurrent index closure.
beb7afd to
afcfb57
Compare
Member
Author
|
@bleskes Sorry, let this one linger. I've updated to add a test, which required refactoring the code to allow it to be a little more testable. |
pickypg
added a commit
that referenced
this pull request
Jun 28, 2017
…#25016) This catches `AlreadyClosedException` during `stats` calls to avoid failing a `_nodes/stats` request because of the ignorable, concurrent index closure.
pickypg
added a commit
that referenced
this pull request
Jun 28, 2017
…#25016) This catches `AlreadyClosedException` during `stats` calls to avoid failing a `_nodes/stats` request because of the ignorable, concurrent index closure.
pickypg
added a commit
that referenced
this pull request
Jun 28, 2017
…#25016) This catches `AlreadyClosedException` during `stats` calls to avoid failing a `_nodes/stats` request because of the ignorable, concurrent index closure.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This catches
AlreadyClosedExceptionduringstatscalls to avoid failing a_nodes/statsrequest because of the ignorable, concurrent index closure.Part of #23099