Move the IndexDeletionPolicy to be engine internal#24930
Merged
bleskes merged 3 commits intoelastic:masterfrom May 29, 2017
Merged
Move the IndexDeletionPolicy to be engine internal#24930bleskes merged 3 commits intoelastic:masterfrom
bleskes merged 3 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
Thx @jasontedor . I will give it a bit and backport. |
Member
|
My preference would be to leave the 5.x branches the same and to not backport this. This branch (master) is going to diverge from the backport anyway. |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 29, 2017
* master: Add a second refresh to concurrent relocation test Add a dummy_index to upgrade tests to ensure we recover fine with replicas (elastic#24937) Rework bwc snapshot projects to build up to two bwc versions (elastic#24870) Move the IndexDeletionPolicy to be engine internal (elastic#24930) [Tests] Harden InternalExtendedStatsTests (elastic#24934) TCorrecting api name (elastic#24924) Add search method to high level REST client (elastic#24796) Add fromXContent method to ClearScrollResponse (elastic#24909) ClearScrollRequest to implement ToXContentObject (elastic#24907) SearchScrollRequest to implement ToXContentObject (elastic#24906) Fix bug in weight computation for query cache
Contributor
Author
|
Sure. I removed the 5.5.0 label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
IndexDeletionPolicyis currently instantiated byIndexShardand is then passed through to the engine as a parameter. That's a shame as it is really just an implementation detail and the engine already has a method to acquire a commit.This is preparing for a follow up PR that will we connect the index deletion policy with a new translog deletion policy.
Relates to #10708