Skip to content

[Test] Add unit tests for InternalHDRPercentilesTests#24157

Merged
tlrx merged 2 commits intoelastic:masterfrom
tlrx:add-test-for-internal-hdr-percentiles
Apr 19, 2017
Merged

[Test] Add unit tests for InternalHDRPercentilesTests#24157
tlrx merged 2 commits intoelastic:masterfrom
tlrx:add-test-for-internal-hdr-percentiles

Conversation

@tlrx
Copy link
Copy Markdown
Member

@tlrx tlrx commented Apr 18, 2017

Related to #22278

@tlrx tlrx added :Analytics/Aggregations Aggregations review >test Issues or PRs that are addressing/adding tests v6.0.0-alpha1 labels Apr 18, 2017
@tlrx tlrx requested a review from jpountz April 18, 2017 12:38
Copy link
Copy Markdown
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


public abstract class InternalPercentilesTestCase<T extends InternalAggregation> extends InternalAggregationTestCase<T> {

private final double[] percents = randomPercents();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be initialized in a junit setup?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right

@tlrx tlrx merged commit 741c031 into elastic:master Apr 19, 2017
@tlrx tlrx deleted the add-test-for-internal-hdr-percentiles branch April 19, 2017 07:37
@tlrx
Copy link
Copy Markdown
Member Author

tlrx commented Apr 19, 2017

Thanks @jpountz

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Apr 19, 2017
* master:
  Add BucketMetricValue interface (elastic#24188)
  Enable index-time sorting (elastic#24055)
  Clarify elasticsearch user uid:gid mapping in Docker docs
  Update field-names-field.asciidoc (elastic#24178)
  ElectMasterService.hasEnoughMasterNodes should return false if no masters were found
  Remove Ubuntu 12.04 (elastic#24161)
  [Test] Add unit tests for InternalHDRPercentilesTests (elastic#24157)
  Replicate write failures (elastic#23314)
  Rename variable in translog simple commit test
  Strengthen translog commit with open view test
  Stronger check in translog prepare and commit test
  Fix translog prepare commit and commit test
  ingest-node.asciidoc - Clarify json processor (elastic#21876)
  Painless: more testing for script_stack (elastic#24168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests v6.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants