Add unit tests for the missing aggregator#23895
Merged
jimczi merged 2 commits intoelastic:masterfrom Apr 4, 2017
jimczi:missing_agg_tests
Merged
Add unit tests for the missing aggregator#23895jimczi merged 2 commits intoelastic:masterfrom jimczi:missing_agg_tests
jimczi merged 2 commits intoelastic:masterfrom
jimczi:missing_agg_tests
Conversation
jpountz
reviewed
Apr 4, 2017
Contributor
jpountz
left a comment
There was a problem hiding this comment.
I left some suggestions.
| new InternalAggregation.ReduceContext(root.context().bigArrays(), null, false)); | ||
| aggs.removeAll(internalAggregations); | ||
| aggs.add(internalAgg); | ||
| aggs = aggs.subList(r, toReduceSize); |
Contributor
There was a problem hiding this comment.
maybe do new ArrayList<>(aggs.subList(r, toReduceSize)); since you call add again below?
| assertEquals(internalMissing.getDocCount(), count.get()); | ||
| count.set(0); | ||
| }); | ||
| } |
Contributor
There was a problem hiding this comment.
maybe also test the case that the field does not exist?
63 tasks
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 4, 2017
* master: Fix Javadocs for BootstrapChecks#enforceLimits Disable bootstrap checks for single-node discovery Add unit tests for the missing aggregator (elastic#23895) Add a property to mark setting as final (elastic#23872) testDifferentRolesMaintainPathOnRestart - fix broken comment testDifferentRolesMaintainPathOnRestart - lower join timeout as split elections are likely Introduce single-node discovery Await termination after shutting down executors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #22278