Skip to content

Accept ingest simulate params as ints or strings#23885

Merged
talevy merged 2 commits intoelastic:masterfrom
sneivandt:fix-23823
Aug 3, 2017
Merged

Accept ingest simulate params as ints or strings#23885
talevy merged 2 commits intoelastic:masterfrom
sneivandt:fix-23823

Conversation

@sneivandt
Copy link
Copy Markdown
Contributor

Update Ingest simulate to accept _id, _index, _type, _routing and _parent as either strings or ints.

Issue #23823.

@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@rjernst rjernst requested a review from talevy June 9, 2017 07:59
@rjernst rjernst added :Distributed/Ingest Node Execution or management of Ingest Pipelines review >enhancement labels Jun 9, 2017
@talevy
Copy link
Copy Markdown
Contributor

talevy commented Jun 9, 2017

hey @sneivandt, apologies for the late response. these changes look good overall!
mind rebasing off latest master to resolve the newly created file conflicts?

Jenkins, please test this

@talevy
Copy link
Copy Markdown
Contributor

talevy commented Jun 13, 2017

@sneivandt thanks for the rebase. think you can add tests around this for parseDocs? either in the rest-spec tests or simulate unite tests

other than that, changes look good!

@talevy
Copy link
Copy Markdown
Contributor

talevy commented Aug 1, 2017

Hi @sneivandt sorry for the late response. I see you added tests (that I missed) Think you can rebase off the latest changes so that we can continue with your PR?

@sneivandt
Copy link
Copy Markdown
Contributor Author

Hey @talevy take a look now. Should be up to date.

@talevy
Copy link
Copy Markdown
Contributor

talevy commented Aug 3, 2017

thanks @sneivandt. looks good! I'll just have our CI run through the checks

jenkins, please test this.

Copy link
Copy Markdown
Contributor

@talevy talevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talevy talevy merged commit 8ef7438 into elastic:master Aug 3, 2017
@talevy talevy added the v7.0.0 label Aug 3, 2017
talevy pushed a commit that referenced this pull request Aug 3, 2017
* Allow ingest simulate to parse _id, _index, _type, _routing and _parent as either string or int (#23823)

* Generate data that includes Integer and String type fields for testing document parsing.
@talevy talevy added the v6.1.0 label Aug 3, 2017
@talevy talevy removed the review label Aug 3, 2017
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants