Fix reindex with a remote source on a version before 2.0.0#23805
Fix reindex with a remote source on a version before 2.0.0#23805jimczi merged 4 commits intoelastic:masterfrom jimczi:reindex_from_remote_1.7
Conversation
jasontedor
left a comment
There was a problem hiding this comment.
LGTM. I think this can safely go into a 5.3 patch release?
bleskes
left a comment
There was a problem hiding this comment.
This is such an important part of our upgrade strategy that i think we need a real integration test for it as well
|
@bleskes it would be great I agree but it's not low hanging fruit to build an IT that launches a node in 1.7 or maybe I missed something ? |
Right. We don't have the infrastructure built to start a 1.7 version of Elasticsearch in the integration test suite. I'd certainly love to have it though. |
|
I filed #23828 to have a look at reindex-from-remote. |
Sorry, to have a look at testing reindex-from-remote more completely. |
|
Thank you Nik. To be clear I by no means meant that the suggested test is a requirement to get this in.
… On 30 Mar 2017, at 7:21 PM, Nik Everett ***@***.***> wrote:
I filed #23828 to have a look at reindex-from-remote.
Sorry, to have a look at testing reindex-from-remote more completely.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I figured as much. I'm really sorry I didn't write those tests after I wrote reindex-from-remote in the first place. It would have saved so much trouble. |
Send the scroll id in the body as plain text when the remote version is before 2.0.0
Send the scroll id in the body as plain text when the remote version is before 2.0.0
Discussed in https://discuss.elastic.co/t/5-3-0-breaks--reindex/80388 and #22931 (comment)
This commit 7520a10#diff-0c925d1f41390dd5d7dd09b6ff5d51d1 in master and v5.3 breaks
reindex from remotewhen the source is on a version before 2.0.0. Thescroll_idis always extracted from a plain text body in ES 1.7 (and before) and does not accept the JSON version that appears in 2.0.0.This change checks the version of the remote cluster and builds the scroll_id in the body depending on the remote version.