Build: remove progress logger hack for gradle 2.13#23679
Merged
rjernst merged 2 commits intoelastic:masterfrom Mar 22, 2017
Merged
Build: remove progress logger hack for gradle 2.13#23679rjernst merged 2 commits intoelastic:masterfrom
rjernst merged 2 commits intoelastic:masterfrom
Conversation
We are now on minimum gradle 3.3, so we no longer need the groovy/gradle hacks used to support both 2.13 and 2.14+.
jasontedor
approved these changes
Mar 22, 2017
Member
jasontedor
left a comment
There was a problem hiding this comment.
I left one very important comment, which I know you'll address before merging. 😇
| progressLogger = new ProgressLogger(args.factory.newOperation(TestProgressLogger)) | ||
| progressLogger.setDescription('Randomized test runner') | ||
| } | ||
| lets us move things around without worrying about breaking things. */ |
Member
There was a problem hiding this comment.
Nit: I thought you were OCD too, how does the indentation being off here by one space not drive you crazy?
Member
Author
There was a problem hiding this comment.
There is more than this one space that bugs me in this code. But you are right, it does bug me, I just did this too fast to notice. :D
rjernst
added a commit
that referenced
this pull request
Mar 22, 2017
We are now on minimum gradle 3.3, so we no longer need the groovy/gradle hacks used to support both 2.13 and 2.14+.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 22, 2017
* master: [API] change wait_for_completion defaults according to docs (elastic#23672) Share XContent rendering code in terms aggs (elastic#23680) Update ingest-node.asciidoc [DOCS] Update the docs about the fact that global ordinals for _parent field are loaded eagerly instead of lazily by default. Build: remove progress logger hack for gradle 2.13 (elastic#23679) Test: Add dump of integ test cluster logs on failure (elastic#23688) Plugins: Add plugin cli specific exit codes (elastic#23599) Plugins: Output better error message when existing plugin is incompatible (elastic#23562) Reindex: wait for cleanup before responding (elastic#23677) Packaging: Remove classpath ordering hack (elastic#23596) Docs: Add note about updating plugins requiring removal and reinstallation (elastic#23597) Build: Make plugin list for smoke tester dynamic (elastic#23601) [TEST] Propertly cleans up failing restore test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are now on minimum gradle 3.3, so we no longer need the groovy/gradle
hacks used to support both 2.13 and 2.14+.