Document some guidelines for students and teachers#23648
Merged
nik9000 merged 1 commit intoelastic:masterfrom Mar 20, 2017
Merged
Document some guidelines for students and teachers#23648nik9000 merged 1 commit intoelastic:masterfrom
nik9000 merged 1 commit intoelastic:masterfrom
Conversation
Short summary: contributing code you wrote for a class is fine, just don't make the contribution process part of a class.
Member
|
Good call adding a link from the pull request template. |
Contributor
|
LGTM 2 thanks @nik9000 |
clintongormley
approved these changes
Mar 20, 2017
nik9000
added a commit
that referenced
this pull request
Mar 20, 2017
Short summary: contributing code you wrote for a class is fine, just don't make the contribution process part of a class.
nik9000
added a commit
that referenced
this pull request
Mar 20, 2017
Short summary: contributing code you wrote for a class is fine, just don't make the contribution process part of a class.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 22, 2017
* master: Fix typo in allocation explain API docs Add unit tests for ReverseNestedAggregator (elastic#23651) Revert "Revert "Build: Upgrade min gradle to 3.3 (elastic#23544)"" Revert "Build: Upgrade min gradle to 3.3 (elastic#23544)" Build: Upgrade min gradle to 3.3 (elastic#23544) Fix took assertion in response filter test Search took time should use a relative clock Adds toString() to snapshot operations in progress Docs: fix a typo in transport client's put-mapping.asciidoc (elastic#23607) Use include-tagged macro for high level client docs (elastic#23438) Update fill-column in .dir-locals.el to 100 characters Setup keystore during integration tests (elastic#22966) Fix typo 'Elastisearch' -> 'Elasticsearch' (elastic#23633) Comment and blank line cleanups (elastic#23647) docs: guidelines for students and teachers (elastic#23648) Fix MapperService StackOverflowError (elastic#23605)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short summary: contributing code you wrote for a class is fine, just
don't make the contribution process part of a class.