Add info method to High Level Rest client#23350
Conversation
javanna
left a comment
There was a problem hiding this comment.
thanks @cbuescher left a couple of comments, LGTM besides those.
There was a problem hiding this comment.
just double checking: when I added ping I thought it doesn't make sense to have an async variant for it, I tend to think the same for info, but let's discuss it, what do others think?
There was a problem hiding this comment.
Is this endpoint documented in the Elasticsearch doc (I didn't find one)? If so, I'd like a link in the Javadoc, otherwise... it's ok :)
There was a problem hiding this comment.
I only found https://www.elastic.co/guide/en/elasticsearch/reference/master/zip-targz.html#_checking_that_elasticsearch_is_running, would that be something you want me to link to?
There was a problem hiding this comment.
everybody ok with not having the async version for it?
There was a problem hiding this comment.
I think these tests are run against a single node cluster, but yes it doesn't necessarily hold. just check that the node name is there? Maybe you want to use ObjectPath (although it will do the same internally)
There was a problem hiding this comment.
can you get this in separately and backport it? I am fine with pushing without a PR if that's handy. I worry that this PR is targeted to master only and depends on stuff that's outside of the rest-high-level folder.
There was a problem hiding this comment.
Opened #23352 and will rebase once that is in.
This commit adds support for an info() method to the High Level Rest client that returns the cluster information usually obtained by performing a `GET hostname:9200` request.
fe20f1b to
2b23be0
Compare
|
@javanna thanks, updated and rebased this after pulling out the changes in MainResponse |
| } | ||
|
|
||
| static Request info() { | ||
| return new Request("GET", "/", Collections.emptyMap(), null); |
There was a problem hiding this comment.
Is this endpoint documented in the Elasticsearch doc (I didn't find one)? If so, I'd like a link in the Javadoc, otherwise... it's ok :)
* master: [TEST] make headers case-insensitive when running yaml tests [TEST] randomize request content_type between all of the supported formats [TEST] add support for binary responses to REST tests infra [TEST] don't check exact size in mapper-size yaml test [TEST] move test for binary field to specific test file that sets Content-Type header explicitly [TEST] move filters aggs wrapper query builder rewriting test to integ tests [TEST] create HttpEntity earlier in REST tests [TEST] Remove content type auto-detection while parsing request body in REST tests Factor out filling of TopDocs in SearchPhaseController (elastic#23380) Add info method to High Level Rest client (elastic#23350) Prevent negative `from` parameter in SearchSourceBuilder (elastic#23358) reduce the number of iterations in testPrimaryRelocationWhileIndexing and flush every 5 rollback unneeded change in testNotifyOnDisconnect disable sampling in testNotifyOnDisconnect
This commit adds support for an info() method to the High Level Rest
client that returns the cluster information usually obtained by performing a
GET hostname:9200request.