UpdateRequest implements ToXContent#23289
Merged
tlrx merged 2 commits intoelastic:masterfrom Feb 21, 2017
Merged
Conversation
This commit changes UpdateRequest so that it implements the ToXContentObject interface.
javanna
approved these changes
Feb 21, 2017
Contributor
javanna
left a comment
There was a problem hiding this comment.
left one comment, LGTM besides that
| } | ||
| if (fetchSourceContext != null) { | ||
| builder.field("_source", fetchSourceContext); | ||
| } |
Contributor
There was a problem hiding this comment.
Shouldn't we print out fields as well?
Member
Author
|
Thanks @javanna ! |
tlrx
added a commit
that referenced
this pull request
Feb 21, 2017
This commit changes UpdateRequest so that it implements the ToXContentObject interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes UpdateRequest so that it implements the ToXContentObject interface. This will be useful for the High Level Rest client when executing UpdateRequests.