Add BulkProcessor methods with XContentType parameter#23078
Merged
jaymode merged 3 commits intoelastic:masterfrom Feb 10, 2017
Merged
Add BulkProcessor methods with XContentType parameter#23078jaymode merged 3 commits intoelastic:masterfrom
jaymode merged 3 commits intoelastic:masterfrom
Conversation
This commit adds methods to the BulkProcessor that accept bytes and a XContentType to avoid content type detection. The methods that do not accept XContentType with bytes have been deprecated by this commit. Relates elastic#22691
javanna
approved these changes
Feb 9, 2017
Contributor
javanna
left a comment
There was a problem hiding this comment.
LGTM shall we maybe have some test call these new methods?
Member
Author
I updated one of the tests to use this method randomly |
Contributor
|
thanks @jaymode looks great. still LGTM |
jaymode
added a commit
that referenced
this pull request
Feb 10, 2017
This commit adds methods to the BulkProcessor that accept bytes and a XContentType to avoid content type detection. The methods that do not accept XContentType with bytes have been deprecated by this commit. Relates #22691
jaymode
added a commit
that referenced
this pull request
Feb 10, 2017
This commit adds methods to the BulkProcessor that accept bytes and a XContentType to avoid content type detection. The methods that do not accept XContentType with bytes have been deprecated by this commit. Relates #22691
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 10, 2017
* master: Fix alias HEAD requests Upgrade to lucene-6.5.0-snapshot-f919485. (elastic#23087) Add BulkProcessor methods with XContentType parameter (elastic#23078)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds methods to the BulkProcessor that accept bytes and a XContentType to avoid content type detection. The
methods that do not accept XContentType with bytes have been deprecated by this commit.
Relates #22691