Improve unit test coverage of aggs#22668
Merged
nik9000 merged 1 commit intoelastic:masterfrom Jan 18, 2017
Merged
Conversation
Add tests for `GlobalAggregator`, `MaxAggregator`, and `InternalMax`. Relates to elastic#22278
Member
Author
Thanks for reviewing! |
Contributor
|
thanks so much for this @nik9000 |
Member
Author
|
master: e71b26f |
63 tasks
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
May 23, 2017
Note that it only extends ESTestCase, it will be used for fromXContent tests only in 5.x This is a partial backport of elastic#22668
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for
GlobalAggregator,MaxAggregator, andInternalMax.Relates to #22278