Painless: Add augmentation to String for base 64#22665
Merged
nik9000 merged 1 commit intoelastic:masterfrom Jan 19, 2017
Merged
Painless: Add augmentation to String for base 64#22665nik9000 merged 1 commit intoelastic:masterfrom
nik9000 merged 1 commit intoelastic:masterfrom
Conversation
We don't want to expose `String#getBytes` which is required for `Base64.getEncoder.encode` to work because we're worried about character sets. This adds `encodeBase64` and `decodeBase64` methods to `String` in Painless that are duals of one another such that: `someString == someString.encodeBase64().decodeBase64()`. Both methods work with the UTF-8 encoding of the string. Closes elastic#22648
Member
Author
|
Hrm, I'll need to add documentation for this too! |
jdconrad
approved these changes
Jan 18, 2017
Contributor
jdconrad
left a comment
There was a problem hiding this comment.
LGTM! Thanks for making this change.
nik9000
added a commit
that referenced
this pull request
Jan 19, 2017
We don't want to expose `String#getBytes` which is required for `Base64.getEncoder.encode` to work because we're worried about character sets. This adds `encodeBase64` and `decodeBase64` methods to `String` in Painless that are duals of one another such that: `someString == someString.encodeBase64().decodeBase64()`. Both methods work with the UTF-8 encoding of the string. Closes #22648
Member
Author
|
Thanks for reviewing @jdconrad and thanks for fixing my tags @clintongormley! |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 20, 2017
* master: (117 commits) Add missing serialization BWC for disk usage estimates Expose disk usage estimates in nodes stats S3 repository: Deprecate specifying credentials through env vars, sys props, and remove profile files (elastic#22567) Fix Eclipse project generation Fix deprecation logging for lenient booleans Remove @Header we no longer need Make lexer abstract [Docs] Remove outdated info about enabling/disabling doc_values (elastic#22694) Move lexer hacks to EnhancedPainlessLexer Fix incorrect args order passed to createAggregator Improve painless's javadocs Add TestWithDependenciesPlugin to build (elastic#22646) Add parsing from xContent to SearchProfileShardResults and nested classes (elastic#22649) Add unit tests for FiltersAggregator (elastic#22678) Don't register search response listener in transport clients unmute FieldStatsIntegrationIT.testGeoPointNotIndexed, fix already pushed Mute FieldStatsIntegrationIT.testGeoPointNotIndexed, for now Painless: Add augmentation to string for base 64 (elastic#22665) Fix NPE on FieldStats with mixed cluster on version pre/post 5.2 (elastic#22688) Add parsing methods for UpdateResponse (elastic#22586) ...
|
Is there any chance to get this into a stable release of 5.2.x? |
Member
Author
|
Not likely. As a policy we don't backport enhancements to patch releases.
Sorry!
…On Wed, Feb 22, 2017, 9:44 PM Sebastian Unger ***@***.***> wrote:
Is there any chance to get this into a stable release of 5.2.x?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#22665 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLorZLDvltSGNDloyf-pGQKYfYk-tGks5rfPKagaJpZM4LmAq->
.
|
|
Any idea when 5.3 will be released? |
Member
I'm really sorry @sebunger but we do not provide release dates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't want to expose
String#getByteswhich is required forBase64.getEncoder.encodeto work because we're worried aboutcharacter sets. This adds
encodeBase64anddecodeBase64methods to
Stringin Painless that are duals of one anothersuch that:
someString == someString.encodeBase64().decodeBase64().Both methods work with the UTF-8 encoding of the string.
Closes #22648