Fix primary relocation for shadow replicas#22474
Merged
ywelsch merged 1 commit intoelastic:masterfrom Jan 8, 2017
Merged
Conversation
ywelsch
added a commit
that referenced
this pull request
Jan 8, 2017
The recovery process started during primary relocation of shadow replicas accesses the engine on the source shard after it's been closed, which results in the source shard failing itself.
ywelsch
added a commit
that referenced
this pull request
Jan 8, 2017
The recovery process started during primary relocation of shadow replicas accesses the engine on the source shard after it's been closed, which results in the source shard failing itself.
ywelsch
added a commit
that referenced
this pull request
Jan 8, 2017
The recovery process started during primary relocation of shadow replicas accesses the engine on the source shard after it's been closed, which results in the source shard failing itself.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 8, 2017
* master: [TEST] Fixed the incorrect indentation for the `skip` clauses in the REST tests Fix primary relocation for shadow replicas (elastic#22474)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary relocation for shadow replicas is broken as the recovery process accesses the engine on the source shard after it's been closed. This results in the source shard failing itself. This has not been detected by tests as, after failing source and target shard of the relocation, the master simply reassigns the primary to the node where it wanted to relocate to as every node has access to the shard files.
Test failure exhibiting behavior (might be an un-related issue though):
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+periodic/1282/consoleFull
Relates to #20300