Improve concurrency of ShardCoreKeyMap.#22316
Merged
jpountz merged 1 commit intoelastic:masterfrom Dec 22, 2016
Merged
Conversation
`ShardCoreKeyMap.add` is called on each segment for all search requests, which means it might become a bottleneck under a cocurrent load of cheap search requests since this method acquires a mutex. This change proposes to use a `ConcurrentHashMap` which allows to only take the mutex in the case that the `LeafReader` has never been seen before.
jasontedor
approved these changes
Dec 22, 2016
Member
jasontedor
left a comment
There was a problem hiding this comment.
Basically double-checked locking, and very-well commented so it's maintained. LGTM.
jpountz
added a commit
that referenced
this pull request
Dec 22, 2016
`ShardCoreKeyMap.add` is called on each segment for all search requests, which means it might become a bottleneck under a cocurrent load of cheap search requests since this method acquires a mutex. This change proposes to use a `ConcurrentHashMap` which allows to only take the mutex in the case that the `LeafReader` has never been seen before.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Dec 22, 2016
* master: (22 commits) Support negative numbers in writeVLong (elastic#22314) UnicastZenPing's PingingRound should prevent opening connections after being closed Add task to clean idea build directory. Make cleanIdea task invoke it. add trace logging to UnicastZenPingTests.testResolveReuseExistingNodeConnections Adds ingest processor headers to exception for unknown processor. (elastic#22315) Remove much ceremony from parsing client yaml test suites (elastic#22311) Support numeric bounds with decimal parts for long/integer/short/byte datatypes (elastic#21972) inner hits: Don't inline inner hits if the query the inner hits is inlined into can't resolve mappings and ignore_unmapped has been set to true Fix stackoverflow error on InternalNumericMetricAggregation Date detection should not rely on a hardcoded set of characters. (elastic#22171) `value_type` is useful regardless of scripting. (elastic#22160) Improve concurrency of ShardCoreKeyMap. (elastic#22316) fixed jdocs and removed already fixed norelease Adds abstract test classes for serialisation (elastic#22281) Introduce translog no-op Provide helpful error message if a plugin exists Clear static variable after suite Repeated language analyzers (elastic#22240) Restore deprecation warning for invalid match_mapping_type values (elastic#22304) Make `-0` compare less than `+0` consistently. (elastic#22173) ...
jpountz
added a commit
that referenced
this pull request
Dec 29, 2016
`ShardCoreKeyMap.add` is called on each segment for all search requests, which means it might become a bottleneck under a cocurrent load of cheap search requests since this method acquires a mutex. This change proposes to use a `ConcurrentHashMap` which allows to only take the mutex in the case that the `LeafReader` has never been seen before.
RickyLau
added a commit
to ElasticsearchClub/elasticsearch
that referenced
this pull request
Mar 12, 2019
Improve concurrency of ShardCoreKeyMap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ShardCoreKeyMap.addis called on each segment for all search requests, whichmeans it might become a bottleneck under a cocurrent load of cheap search
requests since this method acquires a mutex. This change proposes to use a
ConcurrentHashMapwhich allows to only take the mutex in the case that theLeafReaderhas never been seen before.