Prefer joining node with conflicting transport address when becoming master#22134
Merged
ywelsch merged 1 commit intoelastic:masterfrom Dec 14, 2016
Merged
Conversation
…master PR elastic#22049 changed the node update logic to never remove nodes from the cluster state when the cluster state is not published. This led to an issue electing a master (elastic#22120) based on nodes with same transport address (but different node id) as previous nodes. The joining nodes should take precedence over conflicting ones. Note that this only applies to the action of becoming master. If a master is established and a node joins an existing master, it will be rejected if there is another node with same transport address.
|
retest this please |
Contributor
Author
|
Thanks @abeyad |
ywelsch
added a commit
that referenced
this pull request
Dec 14, 2016
…master (#22134) PR #22049 changed the node update logic to never remove nodes from the cluster state when the cluster state is not published. This led to an issue electing a master (#22120) based on nodes with same transport address (but different node id) as previous nodes. The joining nodes should take precedence over conflicting ones. Note that this only applies to the action of becoming master. If a master is established and a node joins an existing master, it will be rejected if there is another node with same transport address.
ywelsch
added a commit
to ywelsch/elasticsearch
that referenced
this pull request
Dec 23, 2016
…master (elastic#22134) PR elastic#22049 changed the node update logic to never remove nodes from the cluster state when the cluster state is not published. This led to an issue electing a master (elastic#22120) based on nodes with same transport address (but different node id) as previous nodes. The joining nodes should take precedence over conflicting ones. Note that this only applies to the action of becoming master. If a master is established and a node joins an existing master, it will be rejected if there is another node with same transport address.
ywelsch
added a commit
that referenced
this pull request
Dec 23, 2016
…master (#22134) PR #22049 changed the node update logic to never remove nodes from the cluster state when the cluster state is not published. This led to an issue electing a master (#22120) based on nodes with same transport address (but different node id) as previous nodes. The joining nodes should take precedence over conflicting ones. Note that this only applies to the action of becoming master. If a master is established and a node joins an existing master, it will be rejected if there is another node with same transport address.
Contributor
Author
|
backported to 5.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #22049 changed the node update logic to never remove nodes from the cluster state when the cluster state is not published. This led to an issue electing a master (#22120) based on nodes with same transport address (but different node id) as previous nodes. The joining nodes should take precedence over conflicting ones as these nodes will also be the ones that have to commit the cluster state. Note that this only applies to the action of becoming master. If a master is established and a node joins an existing master, it will still be rejected if there is another node with same transport address.