Speed up UnicastZenPingTests#21874
Merged
jasontedor merged 1 commit intoelastic:masterfrom Nov 30, 2016
Merged
Conversation
These tests using ping timeouts on the order of seconds, but this is unnecessary since all the sockets are within the same JVM it really should not take that long.
Member
Author
|
On my laptop, this reduces the runtime of these tests from 11.5 seconds to 1.5 seconds. |
Member
|
LGTM |
jasontedor
added a commit
that referenced
this pull request
Nov 30, 2016
These tests using ping timeouts on the order of seconds, but this is unnecessary since all the sockets are within the same JVM it really should not take that long. Relates #21874
Member
Author
|
Thanks @rjernst. |
Contributor
|
Could this change be related to the recent UnicastPingTests.testSimplePings that we are seeing? |
Member
Author
jasontedor
added a commit
that referenced
this pull request
Nov 30, 2016
These tests using ping timeouts on the order of seconds, but this is unnecessary since all the sockets are within the same JVM it really should not take that long. Relates #21874
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests using ping timeouts on the order of seconds, but this is
unnecessary since all the sockets are within the same JVM it really
should not take that long.